Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define _TIME_BITS=64 globally #100461

Merged
merged 1 commit into from
Mar 30, 2024
Merged

Define _TIME_BITS=64 globally #100461

merged 1 commit into from
Mar 30, 2024

Conversation

am11
Copy link
Member

@am11 am11 commented Mar 30, 2024

I wasn't able to test it with docker (wolfcw/libfaketime#437 (comment)), and attempts to emulate arm32 failed on osx-arm64 and win-x64. However, I can confirm that size of st_atime on Debian armel goes from 4 to 8 with _TIME_BITS=64 using this C program:

// FILE: time.c
// COMMAND: cc -D_TIME_BITS=64 time.c
// PLATFORM: Debian armel

#include <sys/types.h>
#include <sys/stat.h>

#include <stdio.h>
#include <unistd.h>

int main(void)
{
    struct stat sb;

    printf("sizeof time_t: %zu\n", sizeof(time_t));
    printf("sizeof stat timestamp: %zu\n", sizeof(sb.st_atime));

    return 0;
}

Contributes to #96460 (pending confirmation once daily build is available)

Copy link
Contributor

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jkotas jkotas merged commit cc7bf83 into dotnet:main Mar 30, 2024
149 of 152 checks passed
@am11 am11 deleted the patch-30 branch March 30, 2024 18:44
@github-actions github-actions bot locked and limited conversation to collaborators Apr 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Infrastructure-coreclr community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants