-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid loading ICU data early during mono startup #100587
Closed
Closed
+40
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tagging subscribers to this area: @dotnet/area-system-globalization |
Tagging subscribers to 'arch-wasm': @lewing |
ilonatommy
reviewed
Apr 3, 2024
src/libraries/System.Private.CoreLib/src/System/Globalization/GlobalizationMode.cs
Show resolved
Hide resolved
Now we need to test/prove this is enough to start runtime without ICU data. |
Let's continue after #99924 landed There is nice Log
cc @kg |
This was referenced Apr 4, 2024
9b2edeb
to
f9951aa
Compare
This was referenced Apr 11, 2024
9ef98b3
to
37ff744
Compare
This was referenced Apr 15, 2024
This was referenced Apr 15, 2024
closing in favor of #100141 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
arch-wasm
WebAssembly architecture
area-System.Globalization
os-browser
Browser variant of arch-wasm
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current mono startup does
AssemblyNameParser
->CreateCultureWithInvariantData
->GlobalizationMode.Invariant
->GlobalizationMode.Settings.cctor
->LoadICU
during startup.This is attempt to postpone loading ICU until really needed.
It matters to Browser OS because we could start the runtime before the ICU data are finished downloading.
We could make this conditional for
#if !TARGET_BROWSER
if necessary.