Enable control flow guard for mono on windows #101293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves binskim warnings for the runtime and aot compilers on windows.
lewing
approved these changes
Apr 19, 2024
lambdageek
approved these changes
Apr 19, 2024
jkotas
reviewed
Apr 19, 2024
jkotas
reviewed
Apr 19, 2024
jkotas
approved these changes
Apr 20, 2024
jkotas
requested changes
Apr 20, 2024
There was a problem hiding this comment.
Build breaks:
2024-04-19T19:57:55.6709922Z MASM : fatal error A1000:cannot open file : $<0:/GUARD:cf
2024-04-19T19:57:55.6712646Z [24/359] Building C object mono\eglib\CMakeFiles\eglib_objects.dir\D_\a\_work\1\s\src\native\minipal\utf8.c.obj
2024-04-19T19:57:55.8142203Z cl : Command line warning D9024 : unrecognized source file type '$<1:/GUARD:cf', object file assumed
2024-04-19T19:57:55.8145990Z cl : Command line warning D9027 : source file '$<1:/GUARD:cf' ignored
akoeplinger
reviewed
Apr 20, 2024
Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
jkotas
approved these changes
Apr 20, 2024
|
Thanks, guys. Figures I missed a > 😂 |
|
/ba-g The failure is similar to #98578 except it's not appearing in the console log and so BA can't capture and relate the failure. |
matouskozak
pushed a commit
to matouskozak/runtime
that referenced
this pull request
Apr 30, 2024
Resolves binskim warnings for the runtime and aot compilers on windows. Co-authored-by: Jan Kotas <jkotas@microsoft.com> Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves binskim warnings for the runtime and aot compilers on windows.