-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wasm] Fix WebSocket failures on wasm test runs #102366
Conversation
/azp run runtime-libraries-mono outerloop |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run runtime-libraries-mono outerloop |
Azure Pipelines successfully started running 1 pipeline(s). |
Could you please also fix all the |
/azp run runtime-libraries-mono outerloop |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run runtime-libraries-mono outerloop |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run runtime-libraries-mono outerloop |
Azure Pipelines successfully started running 1 pipeline(s). |
I find out that
but ignored when passed like
There are 2 ways to go
@lewing @pavelsavara what do you think ? |
/azp run runtime-libraries-mono outerloop |
Azure Pipelines successfully started running 1 pipeline(s). |
All test cases throwing
|
The underlying problem is this xharness issue: dotnet/xharness#908 The PR looks good to me, though maybe we should also spend some time to actually fix xharness instead? |
I'll merge this to reduce pipeline noise until we fix xharness. |
Update test cases to skip on wasm from outerloop attribute.
OuterLoop tests that are disabled still are running when
/p:TestScope=outerloop
.Xharness ignores
-notrait category=failing
and runs tests cases marked withSkipOnPlatform
,ActiveIssue
Fixes #102157