Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main] Update dependencies from dotnet/hotreload-utils, dotnet/icu, dotnet/runtime, dotnet/runtime-assets, dotnet/xharness #102489

Merged
merged 10 commits into from
May 23, 2024

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented May 21, 2024

This pull request updates the following dependencies

From https://github.com/dotnet/xharness

  • Subscription: be30ac4f-4b72-4287-1eb6-08d8d8fef0ea
  • Build: 20240520.4
  • Date Produced: May 20, 2024 1:23:39 PM UTC
  • Commit: 8478d1a9a531e6b1cd26fb8c86400e2efbb8f2f3
  • Branch: refs/heads/main

From https://github.com/dotnet/runtime-assets

  • Subscription: 0c5a34f5-504e-413b-9376-08d8d8ff2d75
  • Build: 20240521.1
  • Date Produced: May 21, 2024 1:20:32 PM UTC
  • Commit: c185f58a7f75bd824a3cd820634cddf27e791d91
  • Branch: refs/heads/main

From https://github.com/dotnet/hotreload-utils

  • Subscription: bfe6dacf-8231-4ea1-e2fe-08d962847885
  • Build: 20240521.3
  • Date Produced: May 21, 2024 1:08:46 PM UTC
  • Commit: 0f56bcca4c73d208ff8c21055fbb16dbb27a3d8a
  • Branch: refs/heads/main

From https://github.com/dotnet/runtime

  • Subscription: 3db4b8c8-0fae-4f82-086c-08dad31ae87d
  • Build: 20240522.3
  • Date Produced: May 22, 2024 7:23:10 PM UTC
  • Commit: b83186a
  • Branch: refs/heads/main

From https://github.com/dotnet/icu

  • Subscription: 4247a230-8931-4538-5b64-08d8d8feb47e
  • Build: 20240522.2
  • Date Produced: May 22, 2024 1:55:54 PM UTC
  • Commit: 68279e320a4b3156693b16ee23be942ed61e9412
  • Branch: refs/heads/dotnet/main

…40520.4

Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
 From Version 9.0.0-prerelease.24266.1 -> To Version 9.0.0-prerelease.24270.4
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-codeflow for labeling automated codeflow label May 21, 2024
…40520.4

Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
 From Version 9.0.0-prerelease.24266.1 -> To Version 9.0.0-prerelease.24270.4
…ld 20240521.1

Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
 From Version 9.0.0-beta.24263.1 -> To Version 9.0.0-beta.24271.1
…ild 20240521.3

Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
 From Version 9.0.0-alpha.0.24263.1 -> To Version 9.0.0-alpha.0.24271.3
…0522.3

Microsoft.DotNet.ILCompiler , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , runtime.native.System.IO.Ports , System.Reflection.Metadata , System.Reflection.MetadataLoadContext , System.Text.Json , Microsoft.SourceBuild.Intermediate.runtime.linux-x64
 From Version 9.0.0-preview.5.24262.2 -> To Version 9.0.0-preview.5.24272.3
@dotnet-maestro dotnet-maestro bot changed the title [main] Update dependencies from dotnet/hotreload-utils, dotnet/runtime-assets, dotnet/xharness [main] Update dependencies from dotnet/hotreload-utils, dotnet/runtime, dotnet/runtime-assets, dotnet/xharness May 22, 2024
@ericstj
Copy link
Member

ericstj commented May 22, 2024

We need this PR to merge to fix an issue if the latest Preview4 SDK is installed - projects will fail to compile because they cannot find AssemblyNameInfo and other types which were recently added to System.Reflection.Metadata. The problem is due to Preview4 having newer FileVersions than the preview5 System.Refelection.Metadata package currently referenced by the repository. A lovely side effect of rebuilding Preview4 and not encoding preview version in the file version - conflict resolution picks the newer file that has less API.

@ericstj
Copy link
Member

ericstj commented May 22, 2024

@sbomer @dotnet/illink can you help have a look at these new build errors:
https://dev.azure.com/dnceng-public/public/_build/results?buildId=684773&view=logs&j=593e9dd6-bcc8-50e3-9fc7-5ded467090f9&t=c83b20c4-ec43-5271-6d5f-0f42a52778aa&l=4748

/_/src/libraries/System.ComponentModel.TypeConverter/src/System/ComponentModel/TypeDescriptor.cs(1745): Trim analysis error IL2026: System.ComponentModel.TypeDescriptor.NodeFor(Object,Boolean): Using member 'System.ComponentModel.TypeDescriptor.ComObjectType.get' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. COM type descriptors are not trim-compatible. [/__w/1/s/src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj]
##[error]/_/src/libraries/System.ComponentModel.TypeConverter/src/System/ComponentModel/TypeDescriptor.cs(1745,0): error IL2026: (NETCORE_ENGINEERING_TELEMETRY=Build) System.ComponentModel.TypeDescriptor.NodeFor(Object,Boolean): Using member 'System.ComponentModel.TypeDescriptor.ComObjectType.get' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. COM type descriptors are not trim-compatible.
/_/src/libraries/System.ComponentModel.TypeConverter/src/System/ComponentModel/TypeDescriptor.cs(1760): Trim analysis error IL2026: System.ComponentModel.TypeDescriptor.NodeFor(Object,Boolean): Using member 'System.ComponentModel.TypeDescriptor.ComObjectType.get' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. COM type descriptors are not trim-compatible. [/__w/1/s/src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj]
##[error]/_/src/libraries/System.ComponentModel.TypeConverter/src/System/ComponentModel/TypeDescriptor.cs(1760,0): error IL2026: (NETCORE_ENGINEERING_TELEMETRY=Build) System.ComponentModel.TypeDescriptor.NodeFor(Object,Boolean): Using member 'System.ComponentModel.TypeDescriptor.ComObjectType.get' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. COM type descriptors are not trim-compatible.
/__w/1/s/.packages/microsoft.dotnet.ilcompiler/9.0.0-preview.5.24272.3/build/Microsoft.NETCore.Native.targets(310,5): error MSB3073: The command ""/__w/1/s/.packages/runtime.linux-x64.microsoft.dotnet.ilcompiler/9.0.0-preview.5.24272.3/tools/ilc" @"/__w/1/s/artifacts/obj/coreclr/ILCompiler/linux.arm64.Release/native/ilc.ilc.rsp"" exited with code -1. [/__w/1/s/src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj]
##[error].packages/microsoft.dotnet.ilcompiler/9.0.0-preview.5.24272.3/build/Microsoft.NETCore.Native.targets(310,5): error MSB3073: (NETCORE_ENGINEERING_TELEMETRY=Build) The command ""/__w/1/s/.packages/runtime.linux-x64.microsoft.dotnet.ilcompiler/9.0.0-preview.5.24272.3/tools/ilc" @"/__w/1/s/artifacts/obj/coreclr/ILCompiler/linux.arm64.Release/native/ilc.ilc.rsp"" exited with code -1.

I see this change - but that was already consumed. 700d724

So perhaps this is due to the new MicrosoftDotNetILCompilerVersion?

@sbomer
Copy link
Member

sbomer commented May 22, 2024

Taking a look.

sbomer and others added 2 commits May 22, 2024 22:11
Microsoft.NETCore.Runtime.ICU.Transport
 From Version 9.0.0-preview.5.24263.1 -> To Version 9.0.0-preview.6.24272.2
@dotnet-maestro dotnet-maestro bot changed the title [main] Update dependencies from dotnet/hotreload-utils, dotnet/runtime, dotnet/runtime-assets, dotnet/xharness [main] Update dependencies from dotnet/hotreload-utils, dotnet/icu, dotnet/runtime, dotnet/runtime-assets, dotnet/xharness May 23, 2024
…40520.4

Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
 From Version 9.0.0-prerelease.24266.1 -> To Version 9.0.0-prerelease.24270.4
…ld 20240521.1

Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
 From Version 9.0.0-beta.24263.1 -> To Version 9.0.0-beta.24271.1
…ild 20240521.3

Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
 From Version 9.0.0-alpha.0.24263.1 -> To Version 9.0.0-alpha.0.24271.3
@ericstj
Copy link
Member

ericstj commented May 23, 2024

@lewing @akoeplinger - a new WASM failure here:

[14:54:36] info: Initializing dotnet version 9.0.0-ci commit hash f13f27bfc5841b5ed10b67162c35d7bfd4856dfb
[14:54:36] info: Running in parallel with 8 threads.
[14:54:36] fail: 
[14:54:36] fail: Unhandled Exception:
[14:54:36] fail: System.TypeLoadException: Could not load type of field 'Mono.Options.OptionSet:ValueOption' (3) due to: Could not resolve type with token 0100002f from typeref (expected class 'System.Text.RegularExpressions.Regex' in assembly 'netstandard, Version=2.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51') assembly:netstandard, Version=2.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51 type:System.Text.RegularExpressions.Regex member:(null)
[14:54:36] fail:    at Microsoft.DotNet.XHarness.TestRunners.Common.ApplicationOptions..cctor()
[14:54:36] info: [0x000fb43c--UI- 14:54:36.940] MONO_WASM: Dumping web worker info as seen by UI thread, it could be stale:
[14:54:36] info: 000 | 0x000fb43c--UI-: isRunning: true isAttached: true isEventLoop:false reuseCount:  0 - UI Thread
[14:54:36] info: 001 | 0x01785ae8-dpty: isRunning: true isAttached: true isEventLoop:false reuseCount:  1 -
[14:54:36] info: 002 | 0x03249620--IO-: isRunning: true isAttached: true isEventLoop:false reuseCount:  1 -
[14:54:36] info: 003 | 0x037518d8-norm: isRunning: true isAttached: true isEventLoop:false reuseCount:  1 - Finalizer
[14:54:36] info: 004 | 0x03ca1860-pool: isRunning: true isAttached: true isEventLoop:false reuseCount:  1 - .NET TP Worker
[14:54:36] info: 005 | 0x03eaa7c8-gate: isRunning: true isAttached: true isEventLoop:false reuseCount:  1 - .NET TP Gate
[14:54:36] info: 006 |           -    : isRunning:false isAttached:false isEventLoop:false reuseCount:  0 - emscripten-pool
[14:54:36] fail: [0x000fb43c--UI- 14:54:36.997] MONO_WASM: The type initializer for 'Microsoft.DotNet.XHarness.TestRunners.Common.ApplicationOptions' threw an exception.
                    at Microsoft.DotNet.XHarness.TestRunners.Common.WasmApplicationEntryPointBase.RunAsync()
                    at Microsoft.DotNet.XHarness.TestRunners.Xunit.WasmApplicationEntryPoint.Run()
                    at WasmTestRunner.Main(String[] args)

Does that look like a flaky failure we can known issue or does it need investigation? https://helixre107v0xdcypoyl9e7f.blob.core.windows.net/dotnet-runtime-refs-pull-102489-merge-d6bd7ef2134d48ce84/WasmTestOnFirefox-MT-Microsoft.Extensions.FileSystemGlobbing.Tests/1/console.2b559dea.log?helixlogtype=result

@akoeplinger
Copy link
Member

This seems unrelated.

@lewing
Copy link
Member

lewing commented May 23, 2024

I opened an KBE that should match

@ericstj
Copy link
Member

ericstj commented May 23, 2024

/ba-g #102615 should apply to the one test failure here. It didn't have the correct message query, I updated it, but it doesn't seem to be running. Merging this since it's blocking folks from using Preview4 + building runtime

@ericstj ericstj merged commit 76367ca into main May 23, 2024
161 of 164 checks passed
@dotnet-maestro dotnet-maestro bot deleted the darc-main-36b1ef06-422d-448b-b4d2-2f186c062948 branch May 23, 2024 17:33
steveharter pushed a commit to steveharter/runtime that referenced this pull request May 28, 2024
…otnet/runtime, dotnet/runtime-assets, dotnet/xharness (dotnet#102489)

* Update dependencies from https://github.com/dotnet/xharness build 20240520.4

Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
 From Version 9.0.0-prerelease.24266.1 -> To Version 9.0.0-prerelease.24270.4

* Update dependencies from https://github.com/dotnet/xharness build 20240520.4

Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
 From Version 9.0.0-prerelease.24266.1 -> To Version 9.0.0-prerelease.24270.4

* Update dependencies from https://github.com/dotnet/runtime-assets build 20240521.1

Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
 From Version 9.0.0-beta.24263.1 -> To Version 9.0.0-beta.24271.1

* Update dependencies from https://github.com/dotnet/hotreload-utils build 20240521.3

Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
 From Version 9.0.0-alpha.0.24263.1 -> To Version 9.0.0-alpha.0.24271.3

* Update dependencies from https://github.com/dotnet/runtime build 20240522.3

Microsoft.DotNet.ILCompiler , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , runtime.native.System.IO.Ports , System.Reflection.Metadata , System.Reflection.MetadataLoadContext , System.Text.Json , Microsoft.SourceBuild.Intermediate.runtime.linux-x64
 From Version 9.0.0-preview.5.24262.2 -> To Version 9.0.0-preview.5.24272.3

* Disable _ComObjectDescriptorSupport in ILCompiler.csproj

* Update dependencies from https://github.com/dotnet/icu build 20240522.2

Microsoft.NETCore.Runtime.ICU.Transport
 From Version 9.0.0-preview.5.24263.1 -> To Version 9.0.0-preview.6.24272.2

* Update dependencies from https://github.com/dotnet/xharness build 20240520.4

Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
 From Version 9.0.0-prerelease.24266.1 -> To Version 9.0.0-prerelease.24270.4

* Update dependencies from https://github.com/dotnet/runtime-assets build 20240521.1

Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
 From Version 9.0.0-beta.24263.1 -> To Version 9.0.0-beta.24271.1

* Update dependencies from https://github.com/dotnet/hotreload-utils build 20240521.3

Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
 From Version 9.0.0-alpha.0.24263.1 -> To Version 9.0.0-alpha.0.24271.3

---------

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Sven Boemer <sbomer@gmail.com>
Ruihan-Yin pushed a commit to Ruihan-Yin/runtime that referenced this pull request May 30, 2024
…otnet/runtime, dotnet/runtime-assets, dotnet/xharness (dotnet#102489)

* Update dependencies from https://github.com/dotnet/xharness build 20240520.4

Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
 From Version 9.0.0-prerelease.24266.1 -> To Version 9.0.0-prerelease.24270.4

* Update dependencies from https://github.com/dotnet/xharness build 20240520.4

Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
 From Version 9.0.0-prerelease.24266.1 -> To Version 9.0.0-prerelease.24270.4

* Update dependencies from https://github.com/dotnet/runtime-assets build 20240521.1

Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
 From Version 9.0.0-beta.24263.1 -> To Version 9.0.0-beta.24271.1

* Update dependencies from https://github.com/dotnet/hotreload-utils build 20240521.3

Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
 From Version 9.0.0-alpha.0.24263.1 -> To Version 9.0.0-alpha.0.24271.3

* Update dependencies from https://github.com/dotnet/runtime build 20240522.3

Microsoft.DotNet.ILCompiler , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , runtime.native.System.IO.Ports , System.Reflection.Metadata , System.Reflection.MetadataLoadContext , System.Text.Json , Microsoft.SourceBuild.Intermediate.runtime.linux-x64
 From Version 9.0.0-preview.5.24262.2 -> To Version 9.0.0-preview.5.24272.3

* Disable _ComObjectDescriptorSupport in ILCompiler.csproj

* Update dependencies from https://github.com/dotnet/icu build 20240522.2

Microsoft.NETCore.Runtime.ICU.Transport
 From Version 9.0.0-preview.5.24263.1 -> To Version 9.0.0-preview.6.24272.2

* Update dependencies from https://github.com/dotnet/xharness build 20240520.4

Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
 From Version 9.0.0-prerelease.24266.1 -> To Version 9.0.0-prerelease.24270.4

* Update dependencies from https://github.com/dotnet/runtime-assets build 20240521.1

Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
 From Version 9.0.0-beta.24263.1 -> To Version 9.0.0-beta.24271.1

* Update dependencies from https://github.com/dotnet/hotreload-utils build 20240521.3

Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
 From Version 9.0.0-alpha.0.24263.1 -> To Version 9.0.0-alpha.0.24271.3

---------

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Sven Boemer <sbomer@gmail.com>
@github-actions github-actions bot locked and limited conversation to collaborators Jun 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-codeflow for labeling automated codeflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants