Commits on May 23, 2024

1. [mono][interp] Fix type of args when inlining method …

   The vars allocated from pushing values on the execution stack might not reflect exactly the actual type of the var. Consider this pattern:
   
   	condbr	BB0
   	newobj	Derived // push var0 of type Derived
   	br	BB1
   BB0:
   	newobj	Base	// push var1 of type Base
   	// here we will end up inserting a `mov var1 -> var0`
   BB1:
   	// top of stack will be seen as being var0
   	call
   
   Because we first reach BB1 with the stack contents of var0, BB1 will end up accessing top of the stack as var0. However the type of var0 at this point is not Derived, since it can also be a Base object. We currently don't update the type of var0, but just update the type information of the top of stack entry when entering BB1. When inlining, after this commit, we use the type information from the stack, rather than the type of the var present on the stack.
   
   In the future we might want to consider updating the type of var0 or creating a new var entirely with the correct type for consistency.

   

   BrzVlad committed May 23, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for 9ed71dc
   • Browse repository at this point

   Copy the full SHA

   9ed71dc View commit details

   Browse the repository at this point in the history