-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Time in ISO strings when deserializing DateOnly #102627
Conversation
Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis |
@dotnet-policy-service agree |
@@ -625,10 +628,6 @@ public static void DateOnly_Read_Nullable_Tests() | |||
[InlineData("\\t2022-05-10")] // Otherwise valid but has leading whitespace | |||
[InlineData("2022-05-10 ")] // Otherwise valid but has trailing whitespace | |||
// Fail on arbitrary ISO dates |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// Fail on arbitrary ISO dates |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It makes sense to allow parsing the date and ignore the time part (why not?) . When having any time zone information in the string, this will not be acceptable because |
Tackles #102594