Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use where T : allows ref struct in runtime #102795

Merged
merged 1 commit into from
Jun 1, 2024
Merged

Use where T : allows ref struct in runtime #102795

merged 1 commit into from
Jun 1, 2024

Conversation

stephentoub
Copy link
Member

Closes #102671

@dotnet-issue-labeler dotnet-issue-labeler bot added needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners new-api-needs-documentation labels May 29, 2024
@dotnet-issue-labeler dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@stephentoub stephentoub added this to the 9.0.0 milestone May 29, 2024
@build-analysis build-analysis bot mentioned this pull request May 29, 2024
Open
@jkotas jkotas added area-System.Runtime and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels May 29, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-runtime
See info in area-owners.md if you want to be subscribed.

This was referenced May 30, 2024
Open
Open
@build-analysis build-analysis bot mentioned this pull request May 30, 2024
Open
3 tasks
@stephentoub stephentoub force-pushed the useallowsrefstructs branch 2 times, most recently from 78385ca to cb4a61c Compare May 31, 2024 16:11
@stephentoub
Copy link
Member Author

Rebased to address conflicts with #102636

This was referenced May 31, 2024
Open
Closed
@stephentoub stephentoub merged commit 7e2e9ae into dotnet:main Jun 1, 2024
146 checks passed
@stephentoub stephentoub deleted the useallowsrefstructs branch June 1, 2024 14:10
This was referenced Jun 1, 2024
Closed
Closed
@lewing lewing mentioned this pull request Jun 4, 2024
Merged
@KalleOlaviNiemitalo KalleOlaviNiemitalo mentioned this pull request Jul 28, 2024
Open
@github-actions github-actions bot locked and limited conversation to collaborators Jul 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@KennethHoff KennethHoff KennethHoff left review comments

@AlekseyTs AlekseyTs AlekseyTs left review comments

@jkotas jkotas jkotas left review comments

@huoyaoyuan huoyaoyuan huoyaoyuan left review comments

@terrajobst terrajobst terrajobst left review comments

@lambdageek lambdageek lambdageek left review comments

@jaredpar jaredpar jaredpar approved these changes

@davidfowl davidfowl davidfowl left review comments

@tannergooding tannergooding tannergooding approved these changes

@AaronRobinsonMSFT AaronRobinsonMSFT Awaiting requested review from AaronRobinsonMSFT

Assignees

@stephentoub stephentoub

Labels
area-System.Runtime new-api-needs-documentation
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.

[API Proposal]: Employ allows ref struct in libraries
10 participants
@stephentoub @davidfowl @jaredpar @lambdageek @terrajobst @huoyaoyuan @jkotas @tannergooding @AlekseyTs @KennethHoff