Dispose XmlReader in SchemaExporter when done #103286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
the
community-contribution
omajid
force-pushed
the
schema-exporter-xmlreader-dispose
branch
from
0f50c2c
to
d9bb905
Compare
to11mtm
reviewed
Jun 12, 2024
| @@ -352,7 +352,8 @@ private XmlElement ExportGenericInfo(Type clrType, string elementName, string el | |||
| ignoreExtensionDataObject: false, preserveObjectReferences: true); | |||
| serializer.WriteObject(xmlWriter, surrogateData); | |||
| xmlWriter.Flush(); | |||
| return (XmlElement?)XmlDoc.ReadNode(XmlReader.Create(new StringReader(stringWriter.ToString()))); | |||
| using var xmlReader = XmlReader.Create(new StringReader(stringWriter.ToString())); | |||
There was a problem hiding this comment.
I think this usage of XmlReader.Create(Stream input) will not dispose the underlying stream.
StringReader doesn't do a whole lot on dispose aside from reset position and null the underlying array...
Might still be worth it however?
There was a problem hiding this comment.
Right, there's no functional benefit to this change; there are no resources here to Dispose.
This was referenced Jun 13, 2024
stephentoub
approved these changes
Jul 9, 2024
matouskozak
added a commit
to matouskozak/runtime
that referenced
this pull request
Jul 11, 2024
This reverts commit 56600b7.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.