Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create portable box helper and wrap the thread-local alloc context in a struct #103607

Merged
merged 8 commits into from
Jun 20, 2024
Merged

Create portable box helper and wrap the thread-local alloc context in a struct #103607

merged 8 commits into from
Jun 20, 2024

Conversation

jkoritzinsky
Copy link
Member

Create a portable box helper and remove the assembly-based one. The codegen is close, but we don't need to be exact as most box operations are inlined anyway

Follow-ups to #103055

@jkoritzinsky
Create a portable box helper and remove the assembly-based one. The c…
3c673e5 
…odegen is close, but we don't need to be exact as most box operations are inlined anyway
@jkoritzinsky
Create a new struct we can put GC-focused thread-locals on (like GC m…
bf77c0d 
…ode, frame/gc frame chains, etc)
@jkoritzinsky jkoritzinsky requested a review from jkotas June 17, 2024 23:00
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

jkotas
jkotas approved these changes Jun 18, 2024
View reviewed changes
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise. Thank you!

@jkotas
Copy link
Member

jkotas commented Jun 18, 2024

Arm32 is failing with asserts like: Assert failure(PID 20 [0x00000014], Thread: 38 [0x0026]): !CREATE_CHECK_STRING((((size_t)this) & 0x7) == (size_t)(pMT->IsValueType()?4:0))

Looks like a problem caused by FEATURE_64BIT_ALIGNMENT.

This was referenced Jun 18, 2024
Closed
Open
Open
Open
@jkoritzinsky @jkotas
Update jithelpers.cpp
bacb5ef 
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
@build-analysis build-analysis bot mentioned this pull request Jun 18, 2024
Closed
jkotas
jkotas reviewed Jun 18, 2024
View reviewed changes
src/coreclr/vm/threads.h Outdated Show resolved Hide resolved
@jkotas
Copy link
Member

jkotas commented Jun 18, 2024

cc @elinor-fung for the cDAC change

This was referenced Jun 19, 2024
Closed
Open
Closed
@jkoritzinsky @elinor-fung
Update src/native/managed/cdacreader/src/Data/RuntimeThreadLocals.cs
89ae1f3 
Co-authored-by: Elinor Fung <elfung@microsoft.com>
@jkoritzinsky jkoritzinsky mentioned this pull request Jun 20, 2024
Closed
@jkoritzinsky
Copy link
Member Author

/ba-g build failure is linked to a known test failure

@build-analysis build-analysis bot mentioned this pull request Jun 20, 2024
Closed
@jkoritzinsky jkoritzinsky merged commit 117cfcc into dotnet:main Jun 20, 2024
144 of 150 checks passed
@jkoritzinsky jkoritzinsky deleted the alloc-context-folllowup branch June 20, 2024 04:04
@chrisnas chrisnas mentioned this pull request Jun 27, 2024
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jkotas jkotas jkotas approved these changes

@elinor-fung elinor-fung elinor-fung approved these changes

@MichalStrehovsky MichalStrehovsky Awaiting requested review from MichalStrehovsky MichalStrehovsky is a code owner

Assignees

@jkoritzinsky jkoritzinsky

Labels
area-VM-coreclr
Projects
AppModel
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jkoritzinsky @jkotas @elinor-fung