Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose JsonElement.DeepEquals #104579

Merged
merged 17 commits into from
Jul 13, 2024
Merged

Expose JsonElement.DeepEquals #104579

merged 17 commits into from
Jul 13, 2024

Conversation

eiriktsarpalis
Copy link
Member

@eiriktsarpalis eiriktsarpalis commented Jul 8, 2024 •
edited
Loading

Fix #33388.

@dotnet-issue-labeler dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@dotnet-issue-labeler dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@eiriktsarpalis eiriktsarpalis self-assigned this Jul 8, 2024
@eiriktsarpalis eiriktsarpalis added this to the 9.0.0 milestone Jul 8, 2024
@build-analysis build-analysis bot mentioned this pull request Jul 9, 2024
Closed
This was referenced Jul 10, 2024
Open
Closed
@build-analysis build-analysis bot mentioned this pull request Jul 11, 2024
Open
This was referenced Jul 11, 2024
Open
Open
eiriktsarpalis and others added 4 commits July 12, 2024 14:34
@eiriktsarpalis @stephentoub
Update src/libraries/System.Text.Json/src/System/Text/Json/Document/J…
87d309f 
…sonElement.cs

Co-authored-by: Stephen Toub <stoub@microsoft.com>
@eiriktsarpalis @stephentoub
Update src/libraries/System.Text.Json/src/System/Text/Json/Document/J…
268dc6f 
…sonElement.cs

Co-authored-by: Stephen Toub <stoub@microsoft.com>
@eiriktsarpalis @stephentoub
Update src/libraries/System.Text.Json/src/System/Text/Json/Document/J…
2f99b16 
…sonElement.cs

Co-authored-by: Stephen Toub <stoub@microsoft.com>
@eiriktsarpalis @stephentoub
Update src/libraries/System.Text.Json/src/System/Text/Json/Document/J…
a4b5c14 
…sonElement.cs

Co-authored-by: Stephen Toub <stoub@microsoft.com>
@eiriktsarpalis eiriktsarpalis merged commit 53a3624 into dotnet:main Jul 13, 2024
74 of 83 checks passed
@eiriktsarpalis eiriktsarpalis deleted the jsonelement-deepequals branch July 13, 2024 04:39
@stephentoub stephentoub mentioned this pull request Jul 23, 2024
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Aug 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stephentoub stephentoub stephentoub approved these changes

@andrewjsaid andrewjsaid andrewjsaid left review comments

@bartonjs bartonjs Awaiting requested review from bartonjs

Assignees

@eiriktsarpalis eiriktsarpalis

Labels
area-System.Text.Json new-api-needs-documentation
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.

System.Text.Json: add ability to do semantic comparisons of JSON values à la JToken.DeepEquals()
4 participants
@eiriktsarpalis @andrewjsaid @stephentoub @bartonjs