Ensure that WaitForPendingFinalizers has seen the expected Full GC count #105289

VSadov · 2024-07-23T00:30:30Z

CoreCLR
NativeAOT
add a test
make the test outerloop

This fixes a long known race that was very rare in the past, but recently started becoming a nuisance. It goes like this:

Some unrelated GC happens, completes, and finalization cycle starts
Finalization thread drains the queue and is just about to report that it is done draining, but gets preempted
User thread makes allocations, calls Collect, calls WaitForPendingFinalizers
Collect runs, pends more items into the queue
User thread waits in WaitForPendingFinalizers on the queue-empty event
The Finalization thread gets to run and signals the event (while the queue is no longer empty)

This forced people to do unnatural things like calling Collect(); WaitForPendingFinalizers(); a few times in a row "to be sure".
That would not help if the objects expected to be finalized are not guaranteed to be unreachable, of course. No number of repeating this would help.
Otherwise doing Collect(); WaitForPendingFinalizers(); just once should be enough.

The fix makes sure that a waiter for the queue drain completion event and the releaser of that water are in agreement on what Full GCs have been certainly handled in the finalization cycle.
In a rare case if the release is too old (in Full GC time), then waiter asks for one more cycle - to make sure there is nothing left in the queue, that the waiter waits for.

dotnet-policy-service · 2024-07-23T06:03:28Z

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

dotnet-policy-service · 2024-07-23T06:03:29Z

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

VSadov · 2024-07-23T14:10:31Z

I think this is ready for a review.

VSadov · 2024-07-23T14:11:32Z

/azp run runtime-nativeaot-outerloop

azure-pipelines · 2024-07-23T14:11:49Z

Azure Pipelines successfully started running 1 pipeline(s).

jkotas · 2024-07-23T20:35:12Z

src/coreclr/vm/finalizerthread.cpp

@@ -580,6 +592,15 @@ void FinalizerThread::FinalizerThreadWait()

        DWORD status;
        status = hEventFinalizerDone->Wait(INFINITE,TRUE);
+
+        if (desiredFullGcCount - g_fullGcCountSeenByFinalization > 0)


I assume that the subtraction and > 0 are to handle GC counts wrapping around. Signed integer overflows are undefined behavior in C++. I am not sure whether it can bite us here. Unsigned integer overflows have fully defined behavior in C++, so it would be more portable to do this with unsigned types.

Yes, a billion of gen2 gc would be a rare, but plausible scenario for a long term service.
I’d prefer the API to return size_t or uint64_t here, but it is what it is. Not sure why signed int was chosen.

We do know that collection counts are monotonically incrementing ticks that may wrap around. I’ll throw in some unsigned casts, just in case the compiler does something unexpected with compares.

One billion seconds is about 30 years. ;)

1-10 times per second is the rough guess for gen2 frequency, I think, excluding stress scenarios. So maybe signed int was chosen because it just does not matter.

jkotas

Nice. Thanks!

mangod9 · 2024-07-23T21:07:04Z

src/libraries/System.Runtime/tests/System.Runtime.Tests/System/GCTests.cs

+            };
+        }
+
+        unsafe class TestObjectWithFinalizer


is unsafe implementation required here?

is unsafe implementation required here?

Not required. I could allocate a mutable class and change a field. It is a testcase, so I used whatever was simpler.

Accessing a local on another thread's stack is technically a UB in the memory model. The current code should work in any known dotnet implementation, but perhaps should change it to just use a class - to not rely on UB.

VSadov · 2024-07-24T18:53:55Z

/azp run runtime-coreclr gcstress-extra, runtime-coreclr gcstress0x3-gcstress0xc

azure-pipelines · 2024-07-24T18:54:08Z

Azure Pipelines successfully started running 2 pipeline(s).

jkotas · 2024-07-24T22:07:49Z

src/coreclr/nativeaot/Runtime/FinalizerHelpers.cpp

+        // we use unsigned math here as the collection counts, which are size_t internally,
+        // can in theory overflow an int and wrap around.
+        // unsigned math would have more defined/portable behavior in such case
+        if ((unsigned int)desiredFullGcCount - (unsigned int)g_fullGcCountSeenByFinalization > 0)


Do you need to cast the result back to int?

unsigned minus unsigned is going to be unsigned. It means that the current version is same as if (desiredFullGcCount != g_fullGcCountSeenByFinalization).

Yes, I think I need a cast to int. The result of unsigned subtraction is indeed unsigned.

Also, I think we see that in gcstress taking long time.

It is relatively fast to run gcstress these days (about 1.5 - 2 hours), but in this PR it's been 3+ hours and nothing completed yet.

VSadov · 2024-07-24T22:57:52Z

/azp run runtime-coreclr gcstress-extra, runtime-coreclr gcstress0x3-gcstress0xc

azure-pipelines · 2024-07-24T22:58:05Z

Azure Pipelines successfully started running 2 pipeline(s).

VSadov · 2024-07-25T04:09:36Z

Thanks!!!

…ll GC count (dotnet#105289)" This reverts commit 54a9efd.

…unt (#105289) * Ensure that WaitForPendingFinalizers has seen the expected Full GC * NativeAOT and some renames * a testcase * make the test not unsafe and make OuterLoop * Use unsigned math when comparing collection ticks * cast the diff to int when comparing gc ticks

…05110) * Remove support for older LLVM versions, and re-order linker flags We have generally tried to support linking multiple versions of LLVM within our git tree. Every new LLVM version moves symbols around between libraries, and as a result, every new version of LLVM requires different linker flags to build. The command line tool `llvm-config` should tell you the exact flags you need, but it is a problem for us when cross-compiling to rely on this, and as a result, we transcribe the result of various llvm-config outputs directly into Mono's CMakeLists.txt. In an effort to support multiple versions of LLVM, flags common between all supported versions were kept in one place, then the version-specific flags appended afterwards. And this has worked fine for years. However: 1. Whilst we only link with `lld`, it is common for contributors and source-build to link with `gold`, `bfd`, or some other GNU-flavoured linker, where library order is essential 2. The list of common libraries to link has remained unchanged for years, but the symbol intra-dependencies may have changed a long time ago, so common symbol order cannot be assumed to remain valid between LLVM versions This has resulted in a long-standing problem for people using e.g. Debian or Ubuntu or GitHub CodeSpaces, rather than always building with one of our dockerfiles representing our "real" build environment, when targeting platforms which use Mono and link LLVM. * Bumping clang and llvm - make docs less ambiguous. (#105401) * Bump main to RC1 (#105338) * Update SDK to preview 6 (#104696) * Update SDK to preview 6 * Update Shared.csproj Fix `error NU1903: Package 'System.Text.Json' 8.0.0 has a known high severity vulnerability` * Fix with existing version. --------- Co-authored-by: Ilona Tomkowicz <32700855+ilonatommy@users.noreply.github.com> Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com> * Change DefaultMaximumErrorResponseLength to KB from Byte (#105396) * Change DefaultMaximumErrorResponseLength to KB from Byte * Handle overflow * Review feedback * Fix warning for MakeGenericType annotation mismatch (#104921) Fixes warning code when a generic type whose type parameters have DAM annotations is used with MakeGenericType, over a type that doesn't have matching annotations. The code IL2070 used to mention the 'this' argument. Instead it should have been IL2071 which mentions the generic argument as the cause of the mismatch. Similar for MakeGenericMethod with IL2090 and IL2091. * Set GCStressIncompatible on GenericContext tests (#104686) Co-authored-by: Vladimir Sadov <vsadov@microsoft.com> * Add runtime config parameter to force ijwhost to load assemblies in an isolated context (#105337) * Add support for isolated load context in LoadInMemoryAssemblyInContext by passing -1 as loadContext * Have ijwhost check a runtime config parameter to determine if it should run in an isolated load context * Added test for ijwhost isolated load context runtime config option * [RISC-V] Fix passing float and uint arguments in VM (#105021) * Add tests * Fix passing float and uint arguments in VM * Change test lib name so it doesn't clash with managed DLL on Windows * Fix platform analyzer attribute order for MacCatalyst (#105409) We need to make sure the attribute for MacCatalyst comes _after_ the iOS one due to how MacCatalyst is a superset of iOS: https://learn.microsoft.com/en-us/dotnet/standard/analyzers/platform-compat-analyzer#platform-inclusion This caused an error in aspnetcore in the latest dependency flow because the analyzer thought AesGcm is _only_ supported on MacCatalyst: > error CA1416: (NETCORE_ENGINEERING_TELEMETRY=Build) This call site is reachable on all platforms. 'AesGcm.Decrypt(ReadOnlySpan<byte>, ReadOnlySpan<byte>, ReadOnlySpan<byte>, Span<byte>, ReadOnlySpan<byte>)' is only supported on: 'maccatalyst' 13.0 and later. * Use correct `ExceptionArgument` value in `System.IO.Pipelines` (#105418) * Remove zlib from requirements script and instruction files (#105419) * Remove zlib from requirements instructions * Remove zlib from native requirements installation script * Revert "Remove zlib from requirements script and instruction files (#105419)" (#105449) This reverts commit 3ec6286. * Ensure that WaitForPendingFinalizers has seen the expected Full GC count (#105289) * Ensure that WaitForPendingFinalizers has seen the expected Full GC * NativeAOT and some renames * a testcase * make the test not unsafe and make OuterLoop * Use unsigned math when comparing collection ticks * cast the diff to int when comparing gc ticks * Migrate to zlib-ng, part 3: Remove zlib and zlib-intel source code and license mentions (second attempt) (#105371) * Remove zlib/ * Remove zlib-intel/ * Remove third party notice * Remove patches * Remove version txts * Remove cgmanifest.json entries * Remove installer third party notice * Update docs --------- Co-authored-by: Jan Kotas <jkotas@microsoft.com> * [browser] Trigger relink on `EmccMaximumHeapSize` change (#105027) * Edit test + trigger relink. * Remove logging to speed up the test + decrease loop runs to prevent "Browser has been disconnected" error. * Feedback - properties are not bool-only anymore. * Fix: workload needed when heap size set. --------- Co-authored-by: Larry Ewing <lewing@microsoft.com> * Delete erroneous Socket test (#105448) * Pull the python dependency from the EmsdkVersion where possible (#105437) * Use `BinaryPrimitives` more in the ILCompiler (#105404) * JIT: use VNVisitReachingVNs in IsVNNeverNegative (#105197) * Set xunit env var to not print output for passing tests (#105392) * Set xunit env var to not print output for passing tests Fixes #103445 * Update xunit.console.targets * Update xunit.console.targets * Some more automated C# modernization in corelib (#105151) * Fix IDE0056 on corelib (indexing can be simplified) * Fix IDE (null check can be simplified) * Fix IDE0078 (use pattern matching) * Fix IDE0019 (use pattern matching) * Fix IDE0066 (use switch expression) * Fix IDE0250 (struct can be made readonly) * Fix nullability warning and address PR feedback * Address PR feedback and revert a downlevel change * Wrap any `?? throw new`s that go beyond 120 characters * Fix ECMA 355 Partition download links (#105454) On https://github.com/dotnet/runtime/blob/main/docs/project/dotnet-standards.md the Partition with Notes download links using HTTP protocol fail to download in Chrome: >Mixed Content: The site at 'https://github.com/' was loaded over a secure connection, but the file at 'https://download.microsoft.com/download/7/3/3/733AD403-90B2-4064-A81E-01035A7FE13C/MS%20Partition%20I.pdf' was redirected through an insecure connection. This file should be served over HTTPS. See https://blog.chromium.org/2020/02/protecting-users-from-insecure.html for more details. (It might be reasonble for somebody else to followup fixing all domains on all pages with regex `\(http://([.a-z0-9-]+)` replacing with `(https://$1`, but I didn't test each blog site supports HTTPS.) * Add swiftcall signature check for `mono_class_try_get_swift_error_class` (#105408) * Add signature check for swiftcall * Handle null values for swift_error_ptr * Enable NativeAOT runtime tests on MacCatalyst (#102882) This PR updates the CLRTest.Execute.Bash.targets file to set the apple run command for MacCatalyst. The command apple just-run used on Apple mobile is not permitted, and apple test requires the a test runner. Additionally, it is necessary to locate Info.plist in the Contents/ directory and the binary in Contents/MacOS/ within the bundle. --------- Co-authored-by: Ivan Povazan <ivan.povazan@gmail.com> * Resolving an antigen failure (#105260) * Resolving an antigen failure * Fix method accessibility so xunit doesn't complain * Support field access on GetType() of T constrained to be Enum (#105351) Adds trimming support for instance.GetType().GetFields(), where instance is a variable of type `T` that is constrained to System.Enum. This includes a change to have ILLink's TypeProxy track a TypeReference instead of TypeDefinition, which was necessary to allow TypeProxy to represent a generic parameter. Note that this only supports the specific case where `GetType()` is called on a variable of type `T` that is constrained to `Enum`. A variable of type `Enum` is not supported, so the following will still warn: ```csharp static void M(Enum v) { v.GetType().GetFields(); } ``` * Update mono to support shuffle for constant inputs (#105299) * Support mono creating xconst in a few more places * Update mono to support shuffle for constant inputs * Ensure that arm64 also accelerates shuffle for non-constant inputs * Ensure OP_XZERO and OP_XONES are recognized as being constant * Ensure shuffle creates a correct instruction when the fsig doesn't match the necessary parameter count * Ensure that getting the index for floating-point shuffle is possible * Ensure the right class handle is passed down to LLVM so overload resolution can function * Make sure we update the original xconst if we mutate it * Return a new constant and instead of mutating the existing one * Insert relevant xcast nodes * Add some asserts around the ecount * Ensure we get the right element type * Ensure we don't create nodes unnecessarily for create_elementwise * Ensure that create_elementwise still works for other vector sizes * Ensure indentation of switch cases is correct for Mono * Make TooDeepJsonDocument test more consistent across platforms (#105445) * Make TooDeepJsonDocument test more consistent across platforms Run the test on a thread with as consistent a stack size as possible so that we don't inadvertently succeed due to having a really large stack. * Disable test on mono * Update the TypeLib embedding and add comments on API use (#105416) There is an undocumented semantic of Win32 Resource APIs. The missing semantic is that all resource type/name strings are transparently converted to uppercase when calling any of the Win32 Resource APIs. We don't want to apply this undocumented semantic to the reader/writer API so we document it instead. We are avoiding applying the behavior since ReadyToRun scenarios are designed to be a byte for byte copy of the resource, including name as it was written by other tooling. * Update docs for ByRefLike with generics for work in .NET 10 (#103318) Co-authored-by: Jan Kotas <jkotas@microsoft.com> * Fix double printing in StressLog and simplify stresslog macros (#105420) * Add support for nested types in the `corelib.h` parser for rooting descriptors (#105432) * Fixed for assertion failure due to not checking if we are processing Eph samples (#105164) * [PERF] Use correct python executable on windows in venv (#105451) * Fix up Fuzzlyn CI scripts for new hardware intrinsics support (#105470) 1) Strip out the extensions in the seed name when using it for file/directory names, since the list of extensions is quite long 2) Limit the number of unreduced/uncategorized example seeds we show * Try to re-enable DeepEquals_TooDeepJsonDocument_ThrowsInsufficientExecutionStackException test on mono (#105509) * zlib-ng: avoid suppressing WD4242 and WD4244 (#105433) WD4242 and WD4244 are compiler warnings that should not be suppressed because the warn about possible loss of data. WD4242 shows up in zlib-ng/arch/*/slide_hash*.c files and comes from the arguments passed to the slide_hash_chain method. WD4244 happens in Windows when building in Debug configuration, in various zlib-ng/deflate*.c files, and comes from the arguments passed to the check_match method. Fixed by: - Adding asserts to verify the values are below the maximum allowed for their type. - Casting them the proper type before passing them as arguments to their methods. - Removing the WD suppressions, which unfortunately also propagated to other unrelated cmake files. - Fixed a similar loss of data error in an unrelated mono file where the warning suppression was propagated due to this. * Delete outdated comments (#105519) * Arm64/Sve: Add FFR register liveness tracking (#105348) * Add tracking of FFR register somewhat workable code cleanup Remove FFR Add all the GetFfr* wip Work with MskCns() model Use physReg approach Remove commented prototypes working Remove bunch of unnecessary code Remove SpecialImport from GetFFR/SetFFR/LoadFirstFaulting some more code cleanup some fixup * Change condition for PhysReg * jit format * review feedback * unspill for LoadVectorFirstFaulting as well * Use the right opReg * skip spilling tracking * review feedback * Use non-existent REG_FFR * Do not reload from FFR for GetFfr() * review feedback * Make just GrabTemp * fix build and formatting * missed another build failure for arm * Fix throwing exception when calling RunClassConstructor on a generic type with a static constructor (#105513) * Fix throwing exception when calling RunClassConstructor on a generic type with a static constructor #99183 seems to have done away with assuming that a generic type's static constructor was always "initialized". As a result, if you call RunClassConstructor on it, the runtime would throw an exception. Fixes #103891 * Apply suggestions from code review --------- Co-authored-by: Jan Kotas <jkotas@microsoft.com> * [RISC-V][LoongArch64] New passing info for floating-point structs (#103945) * Replace StructFloatFieldInfoFlags with FpStructInRegistersInfo which carries also exact field sizes and offsets * Replace StructFloatFieldInfoFlags with FpStruct::Flags in profiler * Remove FpStructInRegistersInfo::FromOldFlags() * Fix duplicating types in HandleInlineArray * Remove signedness from FpStruct::IntKind because most probably we won't need it * Remove old StructFloatFieldInfoFlags calculating routine * Typo in TARGET_LOONGARCH64 * Remove m_returnedFpFieldOffsets from ArgIterator * Add missing ENREGISTERED_PARAMTYPE_MAXSIZE condition to C# version of FpStruct info calculation * Rename RISCV64PassStructInRegister to match settled casing for RiscV in class names * Update hardcoded flags for float and double in ArgIteratorTemplate::ComputeReturnFlags() This fixes JIT/HardwareIntrinsics/General/Vector* tests. * Fix build on other platforms * Update LoongArch to use FpStructInRegistersInfo * Remove unused old flag masks * LoongArch64 typo Co-authored-by: Qiao Pengcheng <qiaopengcheng@loongson.cn> * Missing FpStruct namespace Co-authored-by: Qiao Pengcheng <qiaopengcheng@loongson.cn> * Missing FpStruct namespace Co-authored-by: Qiao Pengcheng <qiaopengcheng@loongson.cn> * Missing FpStruct namespace Co-authored-by: Qiao Pengcheng <qiaopengcheng@loongson.cn> * Use FpStruct namespace everywhere in JIT * JIT review * Update StructFloatFieldInfoFlags description * Revert to hitherto instruction set order as it's not the point of this PR * Unify get{LoongArch,RiscV}64PassFpStructInRegistersInfo JIT interfaces * Use JIT_TO_EE_TRANSITION instead of _LEAF because MethodTable::GetFpStructInRegistersInfo may throw * Remove FpStruct::IntKind, we should have similar info in ClassLayout in JIT * Change JIT interface to return a struct similar to CORINFO_SWIFT_LOWERING to facilitate code unification in the future * Change JIT to use new Swift-like getFpStructLowering * Cache CORINFO_FPSTRUCT_LOWERING * Update LoongArch classifier to use CORINFO_FPSTRUCT_LOWERING * Update StructFloatInfoFlags doc comment on C# * Move StructFloatFieldInfoFlags and FpStructInRegistersInfo out of the JIT interface * Merge LoongArch and RISC-V AOT calculation of FpStructInRegistersInfo because they were identical. Move it to Common\Internal/Runtime because it's no longer exposed in JIT interface. * Don't zero-initialize CORINFO_FPSTRUCT_LOWERING * Add note for CORINFO_FPSTRUCT_LOWERING::loweredElements type --------- Co-authored-by: Qiao Pengcheng <qiaopengcheng@loongson.cn> * Ensure we don't reuse temps when calling fgMorphArgs on LIR nodes (#105508) * Ensure constant evaluation of shifts on xarch broadcast the operand to the correct size (#105487) * Ensure constant evaluation of shifts on xarch broadcast the operand to the correct size * Ensure we don't try to execute AVX2 code on unsupported platforms * Use ConcurrentDictionary in runtimecounters test (#105520) * Use ConcurrentDictionary in runtimecounters test Fixes #105443 * Fix build break * Fix issue 98506 - Excessive exceptions generated in StackTraceSymbols (#105530) * Fix issue 98506 - Excessive exceptions generated in StackTraceSymbols * Code review feedback * Clean up some usages of LowLevelList<T> (#105407) * Fix ShuffleThunk cache heap (#105480) There was a problem with using heap from the related LoaderAllocator for shuffle thunk cache heap. I have tested it again and it seems that the issue is gone. So I am removing the workaround, making the cache use LoaderAllocator local heap. Close #55697 * [browser] Fix computing destination sub path and publish extension target path in Wasm SDK (#105458) * Bump flags to LLVM 19, not 16 --------- Co-authored-by: Larry Ewing <lewing@microsoft.com> Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com> Co-authored-by: Ilona Tomkowicz <32700855+ilonatommy@users.noreply.github.com> Co-authored-by: Carlos Sánchez López <1175054+carlossanlop@users.noreply.github.com> Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com> Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com> Co-authored-by: Ahmet Ibrahim Aksoy <aaksoy@microsoft.com> Co-authored-by: Sven Boemer <sbomer@gmail.com> Co-authored-by: Steve Pfister <steveisok@users.noreply.github.com> Co-authored-by: Vladimir Sadov <vsadov@microsoft.com> Co-authored-by: Mike Oliphant <oliphant@nostatic.org> Co-authored-by: Tomasz Sowiński <tomeksowi@gmail.com> Co-authored-by: xtqqczze <45661989+xtqqczze@users.noreply.github.com> Co-authored-by: Jan Kotas <jkotas@microsoft.com> Co-authored-by: Stephen Toub <stoub@microsoft.com> Co-authored-by: Paulus Pärssinen <paulus.parssinen@gmail.com> Co-authored-by: Egor Bogatov <egorbo@gmail.com> Co-authored-by: Carl Walsh <darthwalsh@gmail.com> Co-authored-by: Milos Kotlar <kotlarmilos@gmail.com> Co-authored-by: Ivan Povazan <ivan.povazan@gmail.com> Co-authored-by: Tanner Gooding <tagoo@outlook.com> Co-authored-by: Aaron Robinson <arobins@microsoft.com> Co-authored-by: Jeremy Koritzinsky <jekoritz@microsoft.com> Co-authored-by: Mukund Raghav Sharma (Moko) <68247673+mrsharm@users.noreply.github.com> Co-authored-by: Cameron Aavik <99771732+caaavik-msft@users.noreply.github.com> Co-authored-by: Jakob Botsch Nielsen <Jakob.botsch.nielsen@gmail.com> Co-authored-by: Kunal Pathak <Kunal.Pathak@microsoft.com> Co-authored-by: Qiao Pengcheng <qiaopengcheng@loongson.cn> Co-authored-by: Mike McLaughlin <mikem@microsoft.com> Co-authored-by: Huo Yaoyuan <huoyaoyuan@hotmail.com> Co-authored-by: Jan Vorlicek <janvorli@microsoft.com> Co-authored-by: Marek Fišera <mara@neptuo.com>

…ll GC count (dotnet#105289)" This reverts commit 54a9efd.

Ensure that WaitForPendingFinalizers has seen the expected Full GC

12aeee5

dotnet-issue-labeler bot added the area-VM-coreclr label Jul 23, 2024

dotnet-policy-service bot assigned VSadov Jul 23, 2024

NativeAOT and some renames

334f1c7

VSadov added the area-NativeAOT-coreclr label Jul 23, 2024

VSadov mentioned this pull request Jul 23, 2024

Test failure: System.Tests.GCTests.KeepAlive_Null #104218

Closed

a testcase

f6b5acf

VSadov marked this pull request as ready for review July 23, 2024 14:10

VSadov requested a review from MichalStrehovsky as a code owner July 23, 2024 14:10

VSadov requested a review from jkotas July 23, 2024 14:10

This was referenced Jul 23, 2024

System.IO.Net5Compat.Tests and System.IO.Tests suddenly exiting with error 137 #100558

Open

SIGKILL (OOM?) while running LibraryImportGenerator.Tests w/o actionable log messages or artifacts dotnet/dnceng#2496

Open

jkotas reviewed Jul 23, 2024

View reviewed changes

jkotas approved these changes Jul 23, 2024

View reviewed changes

mangod9 reviewed Jul 23, 2024

View reviewed changes

VSadov added 2 commits July 24, 2024 10:55

make the test not unsafe and make OuterLoop

55830b1

Use unsigned math when comparing collection ticks

d1d2b7e

mangod9 approved these changes Jul 24, 2024

View reviewed changes

This was referenced Jul 24, 2024

Failed USB connection via port 54050, error 61, in tvOS arm64 Release AllSubsets_Mono #82637

Open

msbuild crashes with "MSB0001: Internal MSBuild Error: must be valid" dotnet/dnceng#3304

Open

This was referenced Jul 24, 2024

WasmTestOnChrome timeouts in CI #105363

Closed

DeepEquals_TooDeepJsonDocument_ThrowsInsufficientExecutionStackException test failure #105425

Closed

jkotas reviewed Jul 24, 2024

View reviewed changes

cast the diff to int when comparing gc ticks

c2b8cf9

AndyAyersMS mentioned this pull request Jul 25, 2024

Test failure: Interop/PInvoke/CriticalHandles/Test/Test/Test.cmd #103939

Closed

This was referenced Jul 25, 2024

The Operation will be canceled. The next steps may not contain expected logs. dotnet/dnceng#3008

Open

DeepEquals_TooDeepJsonDocument_ThrowsInsufficientExecutionStackException doesn't throw #105440

Closed

VSadov merged commit 54a9efd into dotnet:main Jul 25, 2024
154 of 158 checks passed

VSadov deleted the finAnotherCrank branch July 25, 2024 04:10

MichalStrehovsky added a commit to MichalStrehovsky/runtime that referenced this pull request Jul 26, 2024

Revert "Ensure that WaitForPendingFinalizers has seen the expected Fu…

713e0ff

…ll GC count (dotnet#105289)" This reverts commit 54a9efd.

eduardo-vp pushed a commit to eduardo-vp/runtime that referenced this pull request Aug 13, 2024

Revert "Ensure that WaitForPendingFinalizers has seen the expected Fu…

aea29cf

…ll GC count (dotnet#105289)" This reverts commit 54a9efd.

eduardo-vp pushed a commit to eduardo-vp/runtime that referenced this pull request Aug 14, 2024

Revert "Ensure that WaitForPendingFinalizers has seen the expected Fu…

e2eaa66

…ll GC count (dotnet#105289)" This reverts commit 54a9efd.

github-actions bot locked and limited conversation to collaborators Aug 24, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ensure that WaitForPendingFinalizers has seen the expected Full GC count #105289

Ensure that WaitForPendingFinalizers has seen the expected Full GC count #105289

VSadov commented Jul 23, 2024 •

edited

Loading

dotnet-policy-service bot commented Jul 23, 2024

dotnet-policy-service bot commented Jul 23, 2024

VSadov commented Jul 23, 2024

VSadov commented Jul 23, 2024

azure-pipelines bot commented Jul 23, 2024

jkotas Jul 23, 2024 •

edited

Loading

VSadov Jul 24, 2024 •

edited

Loading

VSadov Jul 24, 2024 •

edited

Loading

jkotas left a comment

mangod9 Jul 23, 2024

VSadov Jul 24, 2024 •

edited

Loading

VSadov commented Jul 24, 2024

azure-pipelines bot commented Jul 24, 2024

jkotas Jul 24, 2024

VSadov Jul 24, 2024

VSadov Jul 24, 2024

VSadov Jul 24, 2024 •

edited

Loading

VSadov commented Jul 24, 2024

azure-pipelines bot commented Jul 24, 2024

VSadov commented Jul 25, 2024

Ensure that WaitForPendingFinalizers has seen the expected Full GC count #105289

Ensure that WaitForPendingFinalizers has seen the expected Full GC count #105289

Conversation

VSadov commented Jul 23, 2024 • edited Loading

dotnet-policy-service bot commented Jul 23, 2024

dotnet-policy-service bot commented Jul 23, 2024

VSadov commented Jul 23, 2024

VSadov commented Jul 23, 2024

azure-pipelines bot commented Jul 23, 2024

jkotas Jul 23, 2024 • edited Loading

Choose a reason for hiding this comment

VSadov Jul 24, 2024 • edited Loading

Choose a reason for hiding this comment

VSadov Jul 24, 2024 • edited Loading

Choose a reason for hiding this comment

jkotas left a comment

Choose a reason for hiding this comment

mangod9 Jul 23, 2024

Choose a reason for hiding this comment

VSadov Jul 24, 2024 • edited Loading

Choose a reason for hiding this comment

VSadov commented Jul 24, 2024

azure-pipelines bot commented Jul 24, 2024

jkotas Jul 24, 2024

Choose a reason for hiding this comment

VSadov Jul 24, 2024

Choose a reason for hiding this comment

VSadov Jul 24, 2024

Choose a reason for hiding this comment

VSadov Jul 24, 2024 • edited Loading

Choose a reason for hiding this comment

VSadov commented Jul 24, 2024

azure-pipelines bot commented Jul 24, 2024

VSadov commented Jul 25, 2024

VSadov commented Jul 23, 2024 •

edited

Loading

jkotas Jul 23, 2024 •

edited

Loading

VSadov Jul 24, 2024 •

edited

Loading

VSadov Jul 24, 2024 •

edited

Loading

VSadov Jul 24, 2024 •

edited

Loading

VSadov Jul 24, 2024 •

edited

Loading