Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LoongArch64] delete the LA64's todo within INLINE_GET_TLS_VAR. #106254

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

shushanhf
Copy link
Contributor

delete the LA64's todo when getting the TLS var within INLINE_GET_TLS_VAR.

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Aug 12, 2024
@shushanhf shushanhf added arch-loongarch64 and removed community-contribution Indicates that the PR has been added by a community member labels Aug 12, 2024
@am11
Copy link
Member

am11 commented Aug 12, 2024

Looks great! Is it so that inline TLS is now available on LA64?

@jkotas jkotas merged commit 01f6744 into dotnet:main Aug 12, 2024
88 checks passed
@shushanhf
Copy link
Contributor Author

Looks great! Is it so that inline TLS is now available on LA64?

Yes, the gcc and llvm had supported this.

@am11
Copy link
Member

am11 commented Aug 13, 2024

ok, was curious if two AOT smoke tests which were failing due to the lack of TLS (#104661 (comment)) are now passing?

xen0n added a commit to loongson-community/dotnet-runtime that referenced this pull request Sep 9, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Sep 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-loongarch64 area-NativeAOT-coreclr community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants