-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Networking stress tests infrastructure improvements. #108325
Conversation
/azp run runtime-libraries stress-http |
Tagging subscribers to this area: @dotnet/ncl |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run runtime-libraries stress-http |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run runtime-libraries stress-http |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run runtime-libraries stress-http |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run runtime-libraries stress-http |
/azp run runtime-libraries stress-ssl |
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run runtime-libraries stress-http |
/azp run runtime-libraries stress-http |
/azp run runtime-libraries stress-ssl |
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run runtime-libraries stress-ssl |
/azp run runtime-libraries stress-http |
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
Azure Pipelines successfully started running 1 pipeline(s). |
Stress is running, H/3 stress failure was present before as well. |
@@ -7,7 +7,7 @@ RUN apt-get update -y && \ | |||
apt-get upgrade -y && \ | |||
apt-get install -y cmake clang ruby-dev gem lttng-tools libssl-dev && \ | |||
gem install fpm | |||
RUN git clone --depth 1 --single-branch --branch v2.3.5 --recursive https://github.com/microsoft/msquic | |||
RUN git clone --depth 1 --single-branch --branch v2.4.4 --recursive https://github.com/microsoft/msquic |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need to build msquic? It feels like we should just consume it from packages.microsoft.com ... and simply get latest e.g. no need to vary about particular varian?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's build in Debug (to catch asserts) and with the sanitizer on - which helped us in the past to catch some errors in stress. So that's why we build it inside the image instead of just using a binary package.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note may be useful. It was not obvious to me. I'mwondering if libsmquic-dbg
package would be useful to anybody besides us...
@@ -1,6 +1,6 @@ | |||
# Builds and copies library artifacts into target dotnet sdk image | |||
ARG BUILD_BASE_IMAGE=mcr.microsoft.com/dotnet-buildtools/prereqs:centos-stream9 | |||
ARG SDK_BASE_IMAGE=mcr.microsoft.com/dotnet/nightly/sdk:8.0 | |||
ARG SDK_BASE_IMAGE=mcr.microsoft.com/dotnet/nightly/sdk:latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need to worry about cases when "latest" != VERSION
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not really, we download the nightly SDK anyway for build purposes (there is no docker image for that). "latest" should guarantee we have all necessary prerequisites (I didn't want to use runtime-deps image because it does not have wget)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I left few comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SslStress build-local.ps1
has been left unchanged, we need to update it.
Otherwise looks good, great work!
src/libraries/System.Net.Http/tests/StressTests/HttpStress/build-local.sh
Show resolved
Hide resolved
/azp run runtime-libraries stress-http |
/azp run runtime-libraries stress-ssl |
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
Azure Pipelines successfully started running 1 pipeline(s). |
Test failures are unrelated (this PR does not change anything other than http and ssl stress pipelines |
* Update HttpStress * !fixup Uncomment * Fix linux build-docker-sdk script * Fix linux scripts * Create artifact folders on windows * Fixes * fix permissions on bash scripts * Apply same changes to SslStress * revert some changes * Improve build-local scripts * Update SslStress * Update sslstress yml files * !fixup * mkdir -p in yaml * Revert cli arg change * Reference original envvars * code review changes
Key changes: