Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update SkipOnCoreClrAttributes to RuntimeConfiguration argument #31847

Merged
merged 4 commits into from
Feb 6, 2020
Merged

Update SkipOnCoreClrAttributes to RuntimeConfiguration argument #31847

merged 4 commits into from
Feb 6, 2020

Conversation

safern
Copy link
Member

@safern safern commented Feb 6, 2020

Reacts to changes in: dotnet/arcade#4764

cc: @ViktorHofer @stephentoub

@safern safern added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Feb 6, 2020
@safern
Copy link
Member Author

safern commented Feb 6, 2020

Apparently some tests are not being skipped. Will investigate.

@safern
Copy link
Member Author

safern commented Feb 6, 2020

I put up the fix here: dotnet/arcade#4776

@safern safern removed the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Feb 6, 2020
ViktorHofer
ViktorHofer approved these changes Feb 6, 2020
View reviewed changes
Copy link
Member

@ViktorHofer ViktorHofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls fix the merge conflict in eng/Version.Details.xml. Otherwise looks great.

@safern
Copy link
Member Author

safern commented Feb 6, 2020

pls fix the merge conflict in eng/Version.Details.xml. Otherwise looks great.

Done... lame that I just forgot to do ctrl + save as VSCode doesn't save the file when you choose which changes to preserve 🤦‍♂

@safern
Copy link
Member Author

safern commented Feb 6, 2020

Failure is: #2176

@safern safern merged commit 28627fc into dotnet:master Feb 6, 2020
@safern safern deleted the UpdateSkipOnCoreClrRuntimeConfig branch February 6, 2020 20:31
@ghost ghost added the will_lock_this label Dec 6, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Jan 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ViktorHofer ViktorHofer ViktorHofer approved these changes

Assignees
No one assigned
Labels
area-Infrastructure-libraries
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@safern @ViktorHofer @Dotnet-GitSync-Bot