Make FPU settings configurable for installer

[am11]

#32029

@jkotas, seems like CLR_ARM_FPU_CAPABILITY change in eng/common/toolchain.cmake was overwritten by @dotnet-bot at 4528f84#diff-ee3a7f0d86bfe417f1acbec7d1c0082a. I think the proper way was to push the changes https://github.com/dotnet/arcade/.

eng/common/toolchain.cmake is only used in one place in the runtime repo, so I have copied it to eng/native/ directory, next to where it is used. We can delete this file from dotnet/arcade.

[jkotas]

We can delete this file from dotnet/arcade.

Could you please submit PR to delete it ? There are 3 toolchain.cmake in different directories - should all of them be deleted?

[am11]

Aside, I have ran cmake-format on the copied toolchain.cmake file, using this configuration:

# file: $HOME/cmake-format.config

# -----------------------------
# Options effecting formatting.
# -----------------------------
with section("format"):

  # How wide to allow formatted cmake files
  line_width = 180

  # How many spaces to tab for indent
  tab_size = 4

  # If true, separate flow control names from their parentheses with a space
  separate_ctrl_name_with_space = True

  # If true, separate function names from parentheses with a space
  separate_fn_name_with_space = True

  # If a statement is wrapped to more than one line, than dangle the closing
  # parenthesis on its own line.
  dangle_parens = False

and ran:

pip install cmake_format

cd dotnet-runtime
$HOME/.local/bin/cmake-format -i -c=$HOME/cmake-format.config eng/native/toolchain.cmake

it would be nice if we run it on all *.cmake and **/CMakeLists.txt files at some point and checked in from @dotnet-bot account:

git ls-files :/**/*.cmake :/**/CMakeLists.txt | \
    xargs --null -I{} $HOME/.local/bin/cmake-format -i -c=$HOME/cmake-format.config {}

there are over 1532 cmake files in the repo.

[am11]

Could you please submit PR to delete it ?

Sure. @janvorli, shall we move eng/common/cross to eng/native/cross and delete eng/common/toolchain.cmake and eng/common/cross/ from dotnet/arcade? Seems like dotnet/runtime repo is the only current consumer of those parts of arcade.

[janvorli]

Why do we want to move them out of the arcade? In my view, it belongs to the cross build that can be used by any repo, not just runtime. I would expect corert to use it too. So I would keep it in the arcade.

[janvorli]

Edited the above message: runtime -> arcade

[janvorli]

@jkotas the three versions are: one for Linux, two for Android (arm, arm64). I guess the Android ones could be at least merged together if not into the Linux one. But I haven't looked at them for quite a long time, so I am not sure whether there are any caveats or not.

[janvorli]

@am11 I personally don't like the separate_ctrl_name_with_space = True for everything. While it seems acceptable for conditionals for me, I really don't like it for other stuff like include_directories, message, etc. So maybe unifying it the other way - no space (which seems to be prevalent in our CMakeLists.txt) would be a preferable way.

[am11]

@janvorli, sure, noted. I have reverted the change in eng/ dir and upstream it in dotnet/arcade repo (without formatting). We can do the formatting change separately (perhaps after #31701 is done).

[am11]

@janvorli, is this change ok to check in? Once Arcade is updated, original issue can be closed.

[janvorli]

LGTM, thank you!