AllowNatTraversal is properly set for stopped socket #32603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephentoub
reviewed
Feb 20, 2020
src/libraries/System.Net.Sockets/src/System/Net/Sockets/TCPListener.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Feb 20, 2020
src/libraries/System.Net.Sockets/src/System/Net/Sockets/TCPListener.cs
Outdated
Show resolved
Hide resolved
|
/azp run runtime-libraries outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
stephentoub
reviewed
Feb 21, 2020
src/libraries/System.Net.Sockets/src/System/Net/Sockets/TCPListener.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Net.Sockets/tests/FunctionalTests/TcpListenerTest.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Net.Sockets/tests/FunctionalTests/TcpListenerTest.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Net.Sockets/tests/FunctionalTests/TcpListenerTest.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Net.Sockets/tests/FunctionalTests/TcpListenerTest.cs
Show resolved
Hide resolved
src/libraries/System.Net.Sockets/tests/FunctionalTests/TcpListenerTest.cs
Show resolved
Hide resolved
…tener.cs Co-Authored-By: Stephen Toub <stoub@microsoft.com>
…enerTest.cs Co-Authored-By: Stephen Toub <stoub@microsoft.com>
…enerTest.cs Co-Authored-By: Stephen Toub <stoub@microsoft.com>
…enerTest.cs Co-Authored-By: Stephen Toub <stoub@microsoft.com>
|
/azp run runtime-libraries outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-libraries outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
stephentoub
approved these changes
Feb 21, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If AllowNatTraversal is called on a stopped TcpListener when
_serverSocketis null,allowvalue gets stored in a field. Subsequently, if a new socket is created onStartcall, the saved value is read and the corresponding argument is passed toSetIPProtectionLevelcall.Fixes #32551