Bump maximum ICU library version in Unix System.Globalization.Native #34095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ve on Unix The maximum major version of ICU library that we start scanning at was set to 70 (50 as the minimum supported version + 20) long time ago. The available version of ICU is approaching that limit (it is at 67 now). This change bumps the max scanned version to 80 to give us enough head space for a couple of years (guessing based on the current release rate)
|
@janvorli thanks for updating that. As you are touching the shim, would it make sense to get rid of the block of the condition trying to load the min version first seems wrong to me. |
Right, that is a remainder from the times when the minimum version was the version of ICU at the build time. |
stephentoub
approved these changes
Mar 26, 2020
tarekgh
approved these changes
Mar 26, 2020
safern
approved these changes
Mar 26, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The maximum major version of ICU library that we start scanning at was set to 70
(50 as the minimum supported version + 20) long time ago. The available version
of ICU is approaching that limit (it is at 67 now).
This change bumps the max scanned version to 80 to give us enough head space
for a couple of years (guessing based on the current release rate)
Close #34092