-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add build configuration to generate runtime packs for Android #34192
Add build configuration to generate runtime packs for Android #34192
Conversation
@@ -187,6 +189,13 @@ | |||
<TargetsUnix>true</TargetsUnix> | |||
</PropertyGroup> | |||
</When> | |||
<When Condition="$(OutputRid.StartsWith('android'))"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@akoeplinger is <TargetsLinux>
required here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably not required if it's not used but in general the Targets*
seem to follow the RID graph which has Android->Linux->Unix dependency.
73baade
to
c8b2152
Compare
cee1712
to
48ae937
Compare
Official build PR passes https://dev.azure.com/dnceng/internal/_build/results?buildId=587845&view=results |
48ae937
to
84923a0
Compare
84923a0
to
7ec7c75
Compare
7ec7c75
to
0ffa5d3
Compare
0ffa5d3
to
5ec3cc3
Compare
This PR adds support for generating Android runtime packs, which is intended to be consumed by the Xamarin Android SDK. It takes after #34050 and when that is merged, this PR will rebase off it.