Add logger to cache entry to catch exception #37292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lindexi there is no issue tracking this is there? |
maryamariyan
added
area-Extensions-Caching
and removed
area-Microsoft.Extensions
labels
|
Tagging subscribers to this area: @eerhardt |
src/libraries/Microsoft.Extensions.Caching.Memory/src/CacheEntry.cs
Outdated
Show resolved
Hide resolved
maryamariyan
approved these changes
Jul 16, 2020
maryamariyan
requested changes
Jul 16, 2020
|
@maryamariyan Thank you and I do not know which the EventId is right to use. |
|
close and reopening to retrigger the CI |
|
@maryamariyan The CI is failed, and what should I do? |
|
The PR fails on the step to build native dependencies. @lindexi maybe because the PR was stale a little bit. Do you mind doing a rebase to update the PR? |
lindexi
force-pushed
the
t/lindexi/set-logger-to-cache-entry
branch
from
a312baa
to
4d99c9a
Compare
maryamariyan
approved these changes
Aug 11, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we can see, we can not know the EvictionCallback invoked failed. I want to add the logger to CacheEntry to log the exception
But I don't know if it is suitable to use LogInformation to log the exception
Thank you