Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[interp] Intrinsify span ctor #39195

Merged
merged 4 commits into from
Jul 15, 2020
Merged

[interp] Intrinsify span ctor #39195

merged 4 commits into from
Jul 15, 2020

Conversation

BrzVlad
Copy link
Member

@BrzVlad BrzVlad commented Jul 13, 2020

No description provided.

@ghost
Copy link

ghost commented Jul 13, 2020

Tagging subscribers to this area: @BrzVlad, @lewurm
Notify danmosemsft if you want to be subscribed.

@monojenkins monojenkins mentioned this pull request Jul 13, 2020
Merged
@BrzVlad
[interp] Fix definition of instruction
5d2bd68
@BrzVlad
[interp] Intrinsify span ctor
0b226d5 
It is heavily used in bcl for static read only spans.

In the future we should do copy propagation through its fields so we avoid creating the span in the first place and remove other unecessary opcodes.
@BrzVlad
[interp] Allow method inlining if constructor is intrinsified
9768870
@BrzVlad
Fix case where has_references is not yet initialized
d4f6b0c
@SamMonoRT
Copy link
Member

What kind of perf gain are we looking at with this change ?

@BrzVlad BrzVlad mentioned this pull request Jul 15, 2020
Merged
@BrzVlad BrzVlad merged commit ef2ecfd into dotnet:master Jul 15, 2020
@steveharter
Copy link
Member

I assume this would also help methods like Slice() since that returns a new Span.

@steveharter
Copy link
Member

Here's a simple benchmark doing new Span<byte>(bytes).Slice() (100,000,000 iterations)

Core JIT Mono JIT Mono interpreter
23ms 652 (28x slower than Core) 7597 (330x slower than Core)

@ahsonkhan ahsonkhan mentioned this pull request Jul 26, 2020
Merged
@karelz karelz added this to the 5.0.0 milestone Aug 18, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vargaz vargaz vargaz approved these changes

@alexischr alexischr Awaiting requested review from alexischr

@CoffeeFlux CoffeeFlux Awaiting requested review from CoffeeFlux

@lambdageek lambdageek Awaiting requested review from lambdageek

@thaystg thaystg Awaiting requested review from thaystg

Assignees
No one assigned
Labels
area-Codegen-Interpreter-mono
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.
6 participants
@BrzVlad @SamMonoRT @steveharter @vargaz @karelz @Dotnet-GitSync-Bot