-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Obsolete Uri.EscapeUriString #41501
Obsolete Uri.EscapeUriString #41501
Conversation
Tagging subscribers to this area: @dotnet/ncl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -42,5 +42,8 @@ internal static class Obsoletions | |||
|
|||
internal const string CodeBaseMessage = "Assembly.CodeBase and Assembly.EscapedCodeBase are only included for .NET Framework compatibility. Use Assembly.Location instead."; | |||
internal const string CodeBaseDiagId = "SYSLIB0012"; | |||
|
|||
internal const string EscapeUriStringMessage = "Uri.EscapeUriString can corrupt the Uri string in some cases. Consider using Uri.EscapeDataString instead."; | |||
internal const string EscapeUriStringDiagId = "SYSLIB0013"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This ID is being claimed by #41400
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed it in #41400 as it seems this one has bigger chance to be merged first.
Co-authored-by: Adeel Mujahid <adeelbm@outlook.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wording LGTM, thanks!
@aik-jahoda Can you add this obsoletion to https://github.com/dotnet/runtime/blob/master/docs/project/list-of-obsoletions.md please? |
Part of our Uri.EscapeUriString obsoletion effort #31387.