Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Obsolete Uri.EscapeUriString #41501

Merged
merged 10 commits into from
Sep 1, 2020
Merged

Obsolete Uri.EscapeUriString #41501

merged 10 commits into from
Sep 1, 2020

Conversation

aik-jahoda
Copy link
Contributor

Part of our Uri.EscapeUriString obsoletion effort #31387.

@ghost
Copy link

ghost commented Aug 28, 2020

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

@aik-jahoda aik-jahoda requested review from MihaZupan and a team August 28, 2020 08:55
@aik-jahoda aik-jahoda mentioned this pull request Aug 28, 2020
Closed
MihaZupan
MihaZupan approved these changes Aug 28, 2020
View reviewed changes
Copy link
Member

@MihaZupan MihaZupan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/libraries/System.Runtime/ref/System.Runtime.cs Outdated Show resolved Hide resolved
jkotas
jkotas reviewed Aug 28, 2020
View reviewed changes
src/libraries/Common/src/System/Obsoletions.cs
@@ -42,5 +42,8 @@ internal static class Obsoletions

internal const string CodeBaseMessage = "Assembly.CodeBase and Assembly.EscapedCodeBase are only included for .NET Framework compatibility. Use Assembly.Location instead.";
internal const string CodeBaseDiagId = "SYSLIB0012";

internal const string EscapeUriStringMessage = "Uri.EscapeUriString can corrupt the Uri string in some cases. Consider using Uri.EscapeDataString instead.";
internal const string EscapeUriStringDiagId = "SYSLIB0013";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This ID is being claimed by #41400

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed it in #41400 as it seems this one has bigger chance to be merged first.

@karelz karelz added this to the 6.0.0 milestone Aug 31, 2020
MihaZupan
MihaZupan approved these changes Aug 31, 2020
View reviewed changes
Copy link
Member

@MihaZupan MihaZupan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wording LGTM, thanks!

@jkotas jkotas merged commit c3cfe75 into dotnet:master Sep 1, 2020
@jeffhandley
Copy link
Member

@aik-jahoda Can you add this obsoletion to https://github.com/dotnet/runtime/blob/master/docs/project/list-of-obsoletions.md please?

@ghost ghost locked as resolved and limited conversation to collaborators Dec 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@am11 am11 am11 left review comments

@jkotas jkotas jkotas approved these changes

@MihaZupan MihaZupan MihaZupan approved these changes

Assignees
No one assigned
Labels
area-System.Net
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.
7 participants
@aik-jahoda @jeffhandley @am11 @jkotas @MihaZupan @karelz @Dotnet-GitSync-Bot