Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/5.0] Add Fedora 35 RID #48203

Merged
merged 4 commits into from
Mar 15, 2021
Merged

[release/5.0] Add Fedora 35 RID #48203

merged 4 commits into from
Mar 15, 2021

Conversation

omajid
Copy link
Member

@omajid omajid commented Feb 12, 2021

Fedora rawhide now uses the fedora.35-x64 RID:

$ podman run -it registry.fedoraproject.org/fedora:rawhide /bin/bash -c 'cat /etc/os-release'
NAME=Fedora
VERSION="35 (Container Image Prerelease)"
ID=fedora
VERSION_ID=35
VERSION_CODENAME=""
PLATFORM_ID="platform:f35"
PRETTY_NAME="Fedora 35 (Container Image Prerelease)"
ANSI_COLOR="0;38;2;60;110;180"
LOGO=fedora-logo-icon
CPE_NAME="cpe:/o:fedoraproject:fedora:35"
HOME_URL="https://fedoraproject.org/"
DOCUMENTATION_URL="https://docs.fedoraproject.org/en-US/fedora/rawhide/system-administrators-guide/"
SUPPORT_URL="https://fedoraproject.org/wiki/Communicating_and_getting_help"
BUG_REPORT_URL="https://bugzilla.redhat.com/"
REDHAT_BUGZILLA_PRODUCT="Fedora"
REDHAT_BUGZILLA_PRODUCT_VERSION=rawhide
REDHAT_SUPPORT_PRODUCT="Fedora"
REDHAT_SUPPORT_PRODUCT_VERSION=rawhide
PRIVACY_POLICY_URL="https://fedoraproject.org/wiki/Legal:PrivacyPolicy"
VARIANT="Container Image"
VARIANT_ID=container

This is a backport of #48200

@ghost
Copy link

ghost commented Feb 12, 2021

Tagging subscribers to this area: @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Issue Details

Fedora rawhide now uses the fedora.35-x64 RID:

$ podman run -it registry.fedoraproject.org/fedora:rawhide /bin/bash -c 'cat /etc/os-release'
NAME=Fedora
VERSION="35 (Container Image Prerelease)"
ID=fedora
VERSION_ID=35
VERSION_CODENAME=""
PLATFORM_ID="platform:f35"
PRETTY_NAME="Fedora 35 (Container Image Prerelease)"
ANSI_COLOR="0;38;2;60;110;180"
LOGO=fedora-logo-icon
CPE_NAME="cpe:/o:fedoraproject:fedora:35"
HOME_URL="https://fedoraproject.org/"
DOCUMENTATION_URL="https://docs.fedoraproject.org/en-US/fedora/rawhide/system-administrators-guide/"
SUPPORT_URL="https://fedoraproject.org/wiki/Communicating_and_getting_help"
BUG_REPORT_URL="https://bugzilla.redhat.com/"
REDHAT_BUGZILLA_PRODUCT="Fedora"
REDHAT_BUGZILLA_PRODUCT_VERSION=rawhide
REDHAT_SUPPORT_PRODUCT="Fedora"
REDHAT_SUPPORT_PRODUCT_VERSION=rawhide
PRIVACY_POLICY_URL="https://fedoraproject.org/wiki/Legal:PrivacyPolicy"
VARIANT="Container Image"
VARIANT_ID=container

This is a backport of #48200

Author: omajid
Assignees: -
Labels:

area-Infrastructure-libraries
Milestone: -

@safern
Copy link
Member

safern commented Feb 12, 2021

We need to bump Platforms package version and build it, right?

cc: @Anipik

@omajid omajid changed the title Add Fedora 35 RID [release/5.0] Add Fedora 35 RID Feb 12, 2021
@omajid
Copy link
Member Author

omajid commented Feb 12, 2021

We need to bump Platforms package version and build it, right?

Done now.

@Anipik
Copy link
Contributor

Anipik commented Feb 12, 2021

@rbhanda do we need this change for 5.0.4 ?

@Anipik
Copy link
Contributor

Anipik commented Feb 12, 2021

We need to bump Platforms package version and build it, right?

Anipik
Anipik suggested changes Feb 12, 2021
View reviewed changes
Copy link
Contributor

@Anipik Anipik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@omajid can you update the packageIndex.json as well ? https://github.com/dotnet/runtime/blob/release/5.0/docs/project/library-servicing.md

@omajid
Add Fedora 35 RID
e806448 
Fedora rawhide now uses the fedora.35-x64 RID:

    $ podman run -it registry.fedoraproject.org/fedora:rawhide /bin/bash -c 'cat /etc/os-release'
    NAME=Fedora
    VERSION="35 (Container Image Prerelease)"
    ID=fedora
    VERSION_ID=35
    VERSION_CODENAME=""
    PLATFORM_ID="platform:f35"
    PRETTY_NAME="Fedora 35 (Container Image Prerelease)"
    ANSI_COLOR="0;38;2;60;110;180"
    LOGO=fedora-logo-icon
    CPE_NAME="cpe:/o:fedoraproject:fedora:35"
    HOME_URL="https://fedoraproject.org/"
    DOCUMENTATION_URL="https://docs.fedoraproject.org/en-US/fedora/rawhide/system-administrators-guide/"
    SUPPORT_URL="https://fedoraproject.org/wiki/Communicating_and_getting_help"
    BUG_REPORT_URL="https://bugzilla.redhat.com/"
    REDHAT_BUGZILLA_PRODUCT="Fedora"
    REDHAT_BUGZILLA_PRODUCT_VERSION=rawhide
    REDHAT_SUPPORT_PRODUCT="Fedora"
    REDHAT_SUPPORT_PRODUCT_VERSION=rawhide
    PRIVACY_POLICY_URL="https://fedoraproject.org/wiki/Legal:PrivacyPolicy"
    VARIANT="Container Image"
    VARIANT_ID=container
@omajid
Copy link
Member Author

omajid commented Feb 12, 2021

can you update the packageIndex.json as well

Sure, running a ./build.sh did the trick. I have no idea if all the changes are correct and desired, though.

ViktorHofer
ViktorHofer reviewed Feb 12, 2021
View reviewed changes
Copy link
Member

@ViktorHofer ViktorHofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Anipik can you please take a look at the other packageIndex.json changes in the PR?

@runfoapp runfoapp bot mentioned this pull request Feb 12, 2021
Closed
safern
safern reviewed Feb 12, 2021
View reviewed changes
src/libraries/pkg/baseline/packageIndex.json Outdated
@@ -1551,6 +1545,13 @@
"BaselineVersion": "5.0.1",
"InboxOn": {}
},
"runtime.osx-x64.runtime.native.System.IO.Ports": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Anipik are these changes necessary or should we just update it for the platforms package?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its fine we can keep these, it will help to reduce the noise in future.

@omajid
Copy link
Member Author

omajid commented Mar 11, 2021

Is this okay to merge now?

@Anipik
Copy link
Contributor

Anipik commented Mar 12, 2021

/azp run runtime

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Anipik
Copy link
Contributor

Anipik commented Mar 12, 2021

/azp run runtime-dev-innerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Anipik Anipik merged commit de3aa53 into dotnet:release/5.0 Mar 15, 2021
@omajid
Copy link
Member Author

omajid commented Mar 15, 2021

Thanks for merging this!

@ghost ghost locked as resolved and limited conversation to collaborators Apr 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@safern safern safern left review comments

@ViktorHofer ViktorHofer ViktorHofer approved these changes

@Anipik Anipik Anipik approved these changes

Assignees
No one assigned
Labels
area-Host
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@omajid @safern @Anipik @ViktorHofer @danmoseley