Make sure event generation is incremental #48903
Conversation
|
Related to #47022 |
|
@directhex @akoeplinger @vargaz could someone of you please take a look at this cmake incrementality fix? We are currently short on cmake experts on our team :) |
|
Why do we have to have explicit timestamp files? Are they just dummy files that we keep for other steps to depend on? I presume there are other outputs and you just preferred not to relist all of them as dependencies? |
|
It's a common pattern in CMake to have a single output to represent the running of a target, and let it be a timestamp cmake generates. This is particularly common for places where you have a binary, and you modify it (so you don't generate what looks like a cycle). Also makes the "needs to run" comparison trivial. Yes, you could use byproducts and outputs, but this just felt easier and standard to do this. |
|
/azp run |
|
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
|
Hello @hoyosjs! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
|
/azp run runtime |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
This change doesn't affect Mono. |
* upstream/main: (83 commits) Fix a crash in llvm if the sreg of a setret is not set because the methods ends with a throw. (dotnet#49122) [macOS-arm64] Disable failing libraries tests (dotnet#49400) improve PriorityQueue documentation (dotnet#49392) [wasm] Fix debugger tests (dotnet#49206) [mono] Fix the emission of EnumEqualityComparer instances into the corlib AOT image. (dotnet#49402) jitutils M2M renaming reaction (dotnet#49430) WinHttpHandler: Read HTTP/2 trailing headers [RyuJIT] Make casthelpers cold for sealed classes (dotnet#49295) JIT: Non-void ThrowHelpers (dotnet#48589) Update package index for servicing (dotnet#49417) Remove unnecessary check on polymorphic serialization (dotnet#48464) Remove release build cron triggers from jitstress jobs (dotnet#49333) [main] Update dependencies from dotnet/arcade dotnet/llvm-project dotnet/runtime-assets (dotnet#49359) Implement AppleCryptoNative_X509GetRawData using SecCertificateCopyData [AndroidCrypto] Support a zero-length salt for HMACs. (dotnet#49384) Use managed implementation of pbkdf2 for Android's one-shot implementation. (dotnet#49314) Make 303 redirects do GET like Net Framework (dotnet#49095) Make sure event generation is incremental (dotnet#48903) Add amd and Surface arm64 perf runs (dotnet#49389) Enregister EH var that are single def (dotnet#47307) ...
ghost
locked as resolved and limited conversation to collaborators
@agocke this is what you were seeing. After this there's only some issues with an RC file embedding.