Use managed implementation of pbkdf2 for Android's one-shot implementation. #49314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation. Android does not provide an implementation of Pbkdf2 with other than SHA1 until API Level 26. Since our minimum API level to support is 21, for now we will fall back to the managed implementation. In the future, the Android implementation could optionally use a platform-native implementation when available.
…oneshot-fallback
jkoritzinsky
requested review from
vcsjones,
steveisok,
bartonjs,
AaronRobinsonMSFT and
elinor-fung
|
Tagging subscribers to this area: @bartonjs, @vcsjones, @krwq, @GrabYourPitchforks Issue DetailsAndroid does not provide an implementation of Pbkdf2 with other than SHA1 until API Level 26. Since our minimum API level to support is 21, for now we will fall back to the managed implementation. In the future, the Android implementation could optionally use a platform-native implementation when available.
|
vcsjones
reviewed
Mar 8, 2021
...m.Security.Cryptography.Algorithms/src/Internal/Cryptography/Pbkdf2Implementation.Android.cs
Outdated
Show resolved
Hide resolved
...m.Security.Cryptography.Algorithms/src/Internal/Cryptography/Pbkdf2Implementation.Android.cs
Show resolved
Hide resolved
bartonjs
reviewed
Mar 8, 2021
...m.Security.Cryptography.Algorithms/src/Internal/Cryptography/Pbkdf2Implementation.Android.cs
Outdated
Show resolved
Hide resolved
marek-safar
reviewed
Mar 8, 2021
...s/System.Security.Cryptography.Algorithms/src/System.Security.Cryptography.Algorithms.csproj
Outdated
Show resolved
Hide resolved
bartonjs
approved these changes
Mar 9, 2021
|
Hello @jkoritzinsky! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
|
Failure is unrelated. Will be fixed by #49396 |
thaystg
added a commit
to thaystg/runtime
that referenced
this pull request
Mar 10, 2021
* upstream/main: (83 commits) Fix a crash in llvm if the sreg of a setret is not set because the methods ends with a throw. (dotnet#49122) [macOS-arm64] Disable failing libraries tests (dotnet#49400) improve PriorityQueue documentation (dotnet#49392) [wasm] Fix debugger tests (dotnet#49206) [mono] Fix the emission of EnumEqualityComparer instances into the corlib AOT image. (dotnet#49402) jitutils M2M renaming reaction (dotnet#49430) WinHttpHandler: Read HTTP/2 trailing headers [RyuJIT] Make casthelpers cold for sealed classes (dotnet#49295) JIT: Non-void ThrowHelpers (dotnet#48589) Update package index for servicing (dotnet#49417) Remove unnecessary check on polymorphic serialization (dotnet#48464) Remove release build cron triggers from jitstress jobs (dotnet#49333) [main] Update dependencies from dotnet/arcade dotnet/llvm-project dotnet/runtime-assets (dotnet#49359) Implement AppleCryptoNative_X509GetRawData using SecCertificateCopyData [AndroidCrypto] Support a zero-length salt for HMACs. (dotnet#49384) Use managed implementation of pbkdf2 for Android's one-shot implementation. (dotnet#49314) Make 303 redirects do GET like Net Framework (dotnet#49095) Make sure event generation is incremental (dotnet#48903) Add amd and Surface arm64 perf runs (dotnet#49389) Enregister EH var that are single def (dotnet#47307) ...
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Android does not provide an implementation of Pbkdf2 with other than SHA1 until API Level 26. Since our minimum API level to support is 21, for now we will fall back to the managed implementation.
In the future, the Android implementation could optionally use a platform-native implementation when available.