[macOS-arm64] Disable failing libraries tests #49400
Conversation
M1 helix missing usable libssl
sdmaclea
requested review from
eiriktsarpalis,
Jozkee,
layomia and
steveharter
as code owners
|
Tagging subscribers to this area: @safern, @ViktorHofer, @Anipik Issue DetailsI was able to get one clean Libraries test run in CI with these disabled. Will run a few more times to try to get more intermittent failures.
|
src/libraries/System.IO.MemoryMappedFiles/tests/MemoryMappedViewStreamConformanceTests.cs
Outdated
Show resolved
Hide resolved
| @@ -2,8 +2,11 @@ | |||
| <PropertyGroup> | |||
| <RootNamespace>XmlMiscTests</RootNamespace> | |||
| <TargetFrameworks>$(NetCoreAppCurrent)</TargetFrameworks> | |||
| <!-- ActiveIssue XUnit crashes on Apple Silicon | |||
There was a problem hiding this comment.
I don't have a strong preference, but an approach that the mono folks have been following to bring up tests in new platforms is by disabling their build from libs.tests subset.
runtime/src/libraries/tests.proj
Lines 23 to 65 in 220b01a
This way a local run of all libraries tests .ie: build.cmd libs.tests -test -arch arm64 -os osx would be clean.
Anyway, not a strong preference, I'll leave it up to you since you are doing the bringup.
There was a problem hiding this comment.
Yeah I looked at that too. I thought this way I could see the failures on my local builds if I didn't include IgnoreForCI.
* upstream/main: (83 commits) Fix a crash in llvm if the sreg of a setret is not set because the methods ends with a throw. (dotnet#49122) [macOS-arm64] Disable failing libraries tests (dotnet#49400) improve PriorityQueue documentation (dotnet#49392) [wasm] Fix debugger tests (dotnet#49206) [mono] Fix the emission of EnumEqualityComparer instances into the corlib AOT image. (dotnet#49402) jitutils M2M renaming reaction (dotnet#49430) WinHttpHandler: Read HTTP/2 trailing headers [RyuJIT] Make casthelpers cold for sealed classes (dotnet#49295) JIT: Non-void ThrowHelpers (dotnet#48589) Update package index for servicing (dotnet#49417) Remove unnecessary check on polymorphic serialization (dotnet#48464) Remove release build cron triggers from jitstress jobs (dotnet#49333) [main] Update dependencies from dotnet/arcade dotnet/llvm-project dotnet/runtime-assets (dotnet#49359) Implement AppleCryptoNative_X509GetRawData using SecCertificateCopyData [AndroidCrypto] Support a zero-length salt for HMACs. (dotnet#49384) Use managed implementation of pbkdf2 for Android's one-shot implementation. (dotnet#49314) Make 303 redirects do GET like Net Framework (dotnet#49095) Make sure event generation is incremental (dotnet#48903) Add amd and Surface arm64 perf runs (dotnet#49389) Enregister EH var that are single def (dotnet#47307) ...
ghost
locked as resolved and limited conversation to collaborators
I was able to get one clean Libraries
alltest on Apple Silicon run in CI with these disabled. Will run a few more times to try to get more intermittent failures.