[mono] Fix the emission of EnumEqualityComparer instances into the co… #49402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vargaz
requested review from
CoffeeFlux,
lambdageek,
marek-safar and
SamMonoRT
as code owners
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
…rlib AOT image. Add a few dummy enums to the Mono namespace in corlib, and use them to create valid EnumEqualityComparer instances. Also make sure the instances are actually emitted and not replaced by gsharedvt instances. Fixes dotnet#49229.
vargaz
force-pushed
the
fix-enum-comparer-aot
branch
from
9726f65
to
3914bd8
Compare
CoffeeFlux
reviewed
Mar 10, 2021
| @@ -618,6 +618,15 @@ | |||
| <type fullname="Mono.ValueTuple`3" preserve="fields"/> | |||
| <type fullname="Mono.ValueTuple`4" preserve="fields"/> | |||
| <type fullname="Mono.ValueTuple`5" preserve="fields"/> | |||
| <!-- aot-compiler.c --> | |||
| <type fullname="Mono.I8Enum" preserve="fields"/> | |||
There was a problem hiding this comment.
Should we be splitting these off into a separate exclusions file when building the AOT compiler? Is that an option?
There was a problem hiding this comment.
These types need to be in the linked corlib which is AOTed. They are just small types with no members.
CoffeeFlux
approved these changes
Mar 10, 2021
thaystg
added a commit
to thaystg/runtime
that referenced
this pull request
Mar 10, 2021
* upstream/main: (83 commits) Fix a crash in llvm if the sreg of a setret is not set because the methods ends with a throw. (dotnet#49122) [macOS-arm64] Disable failing libraries tests (dotnet#49400) improve PriorityQueue documentation (dotnet#49392) [wasm] Fix debugger tests (dotnet#49206) [mono] Fix the emission of EnumEqualityComparer instances into the corlib AOT image. (dotnet#49402) jitutils M2M renaming reaction (dotnet#49430) WinHttpHandler: Read HTTP/2 trailing headers [RyuJIT] Make casthelpers cold for sealed classes (dotnet#49295) JIT: Non-void ThrowHelpers (dotnet#48589) Update package index for servicing (dotnet#49417) Remove unnecessary check on polymorphic serialization (dotnet#48464) Remove release build cron triggers from jitstress jobs (dotnet#49333) [main] Update dependencies from dotnet/arcade dotnet/llvm-project dotnet/runtime-assets (dotnet#49359) Implement AppleCryptoNative_X509GetRawData using SecCertificateCopyData [AndroidCrypto] Support a zero-length salt for HMACs. (dotnet#49384) Use managed implementation of pbkdf2 for Android's one-shot implementation. (dotnet#49314) Make 303 redirects do GET like Net Framework (dotnet#49095) Make sure event generation is incremental (dotnet#48903) Add amd and Surface arm64 perf runs (dotnet#49389) Enregister EH var that are single def (dotnet#47307) ...
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rlib AOT image.
Add a few dummy enums to the Mono namespace in corlib, and use them
to create valid EnumEqualityComparer instances. Also make sure the
instances are actually emitted and not replaced by gsharedvt instances.
Fixes #49229.