Updating the JIT to recognize and handle Vector64/128/256<T> for nint/nuint #52016
Conversation
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
Also CC @echesakovMSFT |
|
We already have negative tests assertion that the various APIs throw |
|
Logged #52017 for the API proposal. Most of the surface area is generic and support comes that way. There is also some surface area that can be exposed for cases like: |
Co-authored-by: Anton Lapounov <anton.lapounov@microsoft.com>
tannergooding
force-pushed
the
fix-arm-hang
branch
from
8a13818
to
0fdacc4
Compare
|
cc @dotnet/jit-contrib |
| @@ -1502,7 +1502,7 @@ int MethodTable::GetVectorSize() | |||
| // We need to verify that T (the element or "base" type) is a primitive type. | |||
| TypeHandle typeArg = GetInstantiation()[0]; | |||
| CorElementType corType = typeArg.GetSignatureCorElementType(); | |||
| if (corType >= ELEMENT_TYPE_I1 && corType <= ELEMENT_TYPE_R8) | |||
| if (((corType >= ELEMENT_TYPE_I1) && (corType <= ELEMENT_TYPE_R8)) || (corType == ELEMENT_TYPE_I) || (corType == ELEMENT_TYPE_U)) | |||
There was a problem hiding this comment.
The VM was not correctly handling nint or nuint for the purposes of GetVectorSize() which was impacting downstream decisions about whether it was HFA/HVA and how it should be handled.
|
|
|
@jkotas (for the small VM side change) and @dotnet/jit-contrib could you give this a quick secondary review. It should be good to merge otherwise. |
ghost
locked as resolved and limited conversation to collaborators
This resolves the dotnet/runtime side for dotnet/runtimelab#1035 by recognizing
nintandnuintforVector64/128/256<T>as valid ABI types.The general-purpose methods (such as
As,GetElement,WithElement, etc) are blocked until they go through API review.CC. @jkotas, @AntonLapounov