Improve loop unrolling documentation #52099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minor cleanups to loop unrolling: 1. Add header comments with documentation 2. Make jitIterSmallOverflow/jitIterSmallUnderflow private static `Compiler` class members, and not just "loose" functions. 3. Manually loop hoist ITER_LIMIT and UNROLL_LIMIT_SZ and dependent asserts, plus `iterLimit` setting. Also, make `optCloneLoops` and `optUnrollLoops` return a PhaseStatus, so for early-out cases they can return MODIFIED_NOTHING.
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
No asm diffs |
|
@AndyAyersMS @dotnet/jit-contrib PTAL |
AndyAyersMS
approved these changes
Apr 30, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor cleanups to loop unrolling:
Compilerclass members, and not just "loose" functions.
asserts, plus
iterLimitsetting.Also, make
optCloneLoopsandoptUnrollLoopsreturn a PhaseStatus,so for early-out cases they can return MODIFIED_NOTHING.