Add JSON src-gen support for deserializing with parameterized ctors #56354
Conversation
|
Tagging subscribers to this area: @eiriktsarpalis, @layomia |
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
| @@ -28,10 +33,9 @@ internal abstract class JsonParameterInfo | |||
|
|
|||
| public JsonNumberHandling? NumberHandling { get; private set; } | |||
|
|
|||
| // The zero-based position of the parameter in the formal parameter list. | |||
| public int Position { get; private set; } | |||
| // Using a field to avoid copy semantics. | |||
There was a problem hiding this comment.
More reasons why it should be a class.
There was a problem hiding this comment.
I presume this concern is no longer applicable. Should it be changed into a property?
There was a problem hiding this comment.
Thanks, will update in new PR to avoid CI reset.
...em.Text.Json/src/System/Text/Json/Serialization/Converters/Value/NullableConverterFactory.cs
Show resolved
Hide resolved
layomia
force-pushed
the
SrcGenParamCtors
branch
from
35cc8a2
to
e02ace7
Compare
layomia
force-pushed
the
SrcGenParamCtors
branch
2 times, most recently
from
a7ecaf8
to
5b901b4
Compare
layomia
force-pushed
the
SrcGenParamCtors
branch
from
5b901b4
to
c78013a
Compare
|
New APIs in this PR are in alignment with what was agreed on in API review - #45448 (comment). Some aspects of API review still need more consideration, but not the stuff in this PR. |
There was a problem hiding this comment.
Have not yet reviewed the entire PR, but approving to unblock @layomia for today. Will circle back for more feedback on Monday.
ghost
locked as resolved and limited conversation to collaborators
Also fixes #56182. FYI @avdv, @jasond-s