Prevent cache from being resized #59607
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current implementation, additional work is done if a cache entry has already expired, but the cache is large enough to accept it. Consider the case when
exceedsCapacity = false
andentry.CheckExpired
returns true. The cache first grows even if the entry has expired and then shrinks. It would be great in this case not to perform any manipulations regarding the cache size.The approach I suggested would only change that expired entries won't be able to trigger cache compaction. (
exceedsCapacity = true
andentry.CheckExpired
returns true)