Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix EventSourceGenerator generated file extension #64534

Merged
merged 1 commit into from
Jan 31, 2022
Merged

Fix EventSourceGenerator generated file extension #64534

merged 1 commit into from
Jan 31, 2022

Conversation

stephentoub
Copy link
Member

Contributes to #51058

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost ghost assigned stephentoub Jan 31, 2022
@stephentoub stephentoub mentioned this pull request Jan 31, 2022
Closed
danmoseley
danmoseley approved these changes Jan 31, 2022
View reviewed changes
Copy link
Member

@danmoseley danmoseley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This and the Interop generator should also probably be emitting [GeneratedCodeAttribute] like the other generators.

@ghost
Copy link

ghost commented Jan 31, 2022

Tagging subscribers to this area: @tarekgh, @tommcdon, @pjanotti, @safern
See info in area-owners.md if you want to be subscribed.

Issue Details

Contributes to #51058

Author: stephentoub
Assignees: stephentoub
Labels:

area-System.Diagnostics.Tracing
Milestone: -

@danmoseley
Copy link
Member

Should I open issues for [GeneratedCodeAttribute] or do you believe it's immaterial? Not sure what it triggers.

@stephentoub
Copy link
Member Author

Should I open issues for [GeneratedCodeAttribute]

Sure, it's good hygiene.

@danmoseley danmoseley mentioned this pull request Jan 31, 2022
Open
@danmoseley
Copy link
Member

Opened #64541

@stephentoub stephentoub merged commit 943c8eb into dotnet:main Jan 31, 2022
@stephentoub stephentoub deleted the changesuffix branch January 31, 2022 16:46
@ghost ghost locked as resolved and limited conversation to collaborators Mar 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@danmoseley danmoseley danmoseley approved these changes

@ViktorHofer ViktorHofer ViktorHofer approved these changes

Assignees

@stephentoub stephentoub

Labels
area-System.Diagnostics.Tracing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stephentoub @danmoseley @ViktorHofer