Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm] Some cleanup of wasm jobs in runtime-extra-platforms #64766

Merged
merged 3 commits into from
Feb 4, 2022
Merged

[wasm] Some cleanup of wasm jobs in runtime-extra-platforms #64766

merged 3 commits into from
Feb 4, 2022

Conversation

radical
Copy link
Member

@radical radical commented Feb 3, 2022

  • Remove WBT from extra-platforms, as it runs in runtime, and runtime-staging
  • Run library tests on NodeJS for windows too in runtime-extra-platforms.

@radical radical added api-suggestion Early API idea and discussion, it is NOT ready for implementation area-Infrastructure-mono labels Feb 3, 2022
@ghost ghost assigned radical Feb 3, 2022
@ghost
Copy link

ghost commented Feb 3, 2022

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details
  • Remove WBT from extra-platforms, as it runs in runtime, and runtime-staging
  • Run library tests on NodeJS for windows too in runtime-extra-platforms.
Author: radical
Assignees: -
Labels:

api-suggestion, area-Infrastructure-mono
Milestone: -

@radical
Copy link
Member Author

radical commented Feb 3, 2022

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical radical added arch-wasm WebAssembly architecture and removed api-suggestion Early API idea and discussion, it is NOT ready for implementation labels Feb 3, 2022
@ghost
Copy link

ghost commented Feb 3, 2022

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details
  • Remove WBT from extra-platforms, as it runs in runtime, and runtime-staging
  • Run library tests on NodeJS for windows too in runtime-extra-platforms.
Author: radical
Assignees: radical
Labels:

arch-wasm, area-Infrastructure-mono
Milestone: -

@radical
Copy link
Member Author

radical commented Feb 3, 2022

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical radical mentioned this pull request Feb 3, 2022
Closed
@radical radical added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Feb 4, 2022
This was referenced Feb 4, 2022
Closed
Closed
@radical radical removed the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Feb 4, 2022
@radical
Copy link
Member Author

radical commented Feb 4, 2022

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara
Copy link
Member

cc @maraf

@runfoapp runfoapp bot mentioned this pull request Feb 4, 2022
Closed
@radical radical requested a review from sbomer February 4, 2022 16:17
@radical
Copy link
Member Author

radical commented Feb 4, 2022

Failures are unrelated, and existing issues.

@radical radical mentioned this pull request Feb 4, 2022
Merged
@radical radical requested a review from premun February 4, 2022 16:54
@radical radical merged commit 078eb57 into dotnet:main Feb 4, 2022
@radical radical deleted the wasm-yml branch February 4, 2022 19:18
@ghost ghost locked as resolved and limited conversation to collaborators Mar 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@steveisok steveisok steveisok approved these changes

@sbomer sbomer sbomer approved these changes

@lewing lewing Awaiting requested review from lewing

@pavelsavara pavelsavara Awaiting requested review from pavelsavara

@safern safern Awaiting requested review from safern

@akoeplinger akoeplinger Awaiting requested review from akoeplinger

@premun premun Awaiting requested review from premun

Assignees

@radical radical

Labels
arch-wasm WebAssembly architecture area-Infrastructure-mono
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@radical @pavelsavara @steveisok @sbomer