Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mono]Disable failing intrinsics tests for llvmaot CI lane, due to disabling LLVM JIT #75768

Merged
merged 5 commits into from
Sep 19, 2022

Conversation

fanyang-mono
Copy link
Member

@fanyang-mono fanyang-mono commented Sep 16, 2022

Fix #75606

also:

CI: Library tests should run on library changes
- installer builds, and runtime tests also depend on this

src/tests/issues.targets Outdated Show resolved Hide resolved
@fanyang-mono fanyang-mono changed the title [Mono]Disable failing intrinsics tests, due to disabling LLVM JIT [Mono]Disable failing intrinsics tests for llvmaot CI lane, due to disabling LLVM JIT Sep 16, 2022
@fanyang-mono
Copy link
Member Author

@radical There are more fixes needed here. When editing issues.target file, we need to run runtime tests on all platforms, to ensure that the change is correct.

@radical
Copy link
Member

radical commented Sep 16, 2022

@radical There are more fixes needed here. When editing issues.target file, we need to run runtime tests on all platforms, to ensure that the change is correct.

The runtime tests are not running because of some dependencies getting skipped, and thus the runtime tests also get skipped :/ But I already have fixes for this in #75555 . I'll extract the relevant bits and push here.

@fanyang-mono
Copy link
Member Author

@radical The runtime test CI lanes are running now. Should I merge this PR with your change once the tests pass?

@radical
Copy link
Member

radical commented Sep 16, 2022

Yes, please!

@fanyang-mono fanyang-mono merged commit 2f3fcca into dotnet:main Sep 19, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Oct 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mono JIT/HardwareIntrinsics - Massive failures
3 participants