Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #75070 - Add PriorityQueue DequeueEnqueue Method #75993

Merged
merged 3 commits into from
Sep 29, 2022
Merged

Issue #75070 - Add PriorityQueue DequeueEnqueue Method #75993

merged 3 commits into from
Sep 29, 2022

Conversation

RyanThomas73
Copy link
Contributor

@RyanThomas73 RyanThomas73 commented Sep 21, 2022 •
edited
Loading

Add a DequeueEnqueue method to the System.Collections.Generic.PriorityQueue public api
Add unit test cases for the new method

Fixes #75070

@RyanThomas73
Issue dotnet#75070 - Add a DequeueEnqueue method to the System.Collec…
9992aba 
…tions.Generic.PriorityQueue public api and unit test cases for the new method
@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Sep 21, 2022
@dnfadmin
Copy link

dnfadmin commented Sep 21, 2022 •
edited
Loading

CLA assistant check
All CLA requirements met.

@ghost
Copy link

ghost commented Sep 21, 2022

Tagging subscribers to this area: @dotnet/area-system-collections
See info in area-owners.md if you want to be subscribed.

Issue Details

Add a DequeueEnqueue method to the System.Collections.Generic.PriorityQueue public api
Add unit test cases for the new method

Author: RyanThomas73
Assignees: -
Labels:

area-System.Collections, new-api-needs-documentation
Milestone: -

@danmoseley
Copy link
Member

danmoseley commented Sep 21, 2022 •
edited
Loading

Thanks for the contribution @RyanThomas73 ..if you edit your top comment to add a line like "Fixes #75070" then the issue will be closed when this merges.

eiriktsarpalis
eiriktsarpalis previously approved these changes Sep 22, 2022
View reviewed changes
Copy link
Member

@eiriktsarpalis eiriktsarpalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great -- thanks! I left some feedback concerning tests.

@eiriktsarpalis eiriktsarpalis self-assigned this Sep 22, 2022
@eiriktsarpalis eiriktsarpalis added this to the 8.0.0 milestone Sep 22, 2022
@RyanThomas73
Issue dotnet#75070 - Remove unnecessary PriorityQueue DequeueEnqueue …
64ee658 
…property test case and update DequeueEnqueue test assertion and xunit attribute
@eiriktsarpalis eiriktsarpalis dismissed their stale review September 22, 2022 13:33

Action required on test code

@RyanThomas73
Item dotnet#75070 - Revert the unnecessary name changes to the Priori…
9df8c8d 
…tyQueue.PropertyTests.cs test case method names
@eiriktsarpalis eiriktsarpalis merged commit 6ee3776 into dotnet:main Sep 29, 2022
@RyanThomas73 RyanThomas73 deleted the ryanthomas/main/75070_PriorityQueue_DequeueEnqueueMethod branch September 29, 2022 14:46
@ghost ghost locked as resolved and limited conversation to collaborators Nov 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eiriktsarpalis eiriktsarpalis eiriktsarpalis approved these changes

Assignees

@eiriktsarpalis eiriktsarpalis

Labels
area-System.Collections community-contribution Indicates that the PR has been added by a community member new-api-needs-documentation
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

[API Proposal]: Add a DequeueEnqueue method to the PriorityQueue Type
4 participants
@RyanThomas73 @dnfadmin @danmoseley @eiriktsarpalis