[release/7.0] [mono][debugger] fix exception while decoding value that has a byref field #76086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: Larry Ewing <lewing@microsoft.com>
github-actions
bot
requested review from
thaystg,
radical and
marek-safar
as code owners
|
Tagging subscribers to this area: @thaystg Issue DetailsBackport of #75774 to release/7.0 /cc @thaystg Customer ImpactTestingRiskIMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.
|
|
@rokonec mutex timeout here |
|
@thaystg please fill out the template, add the |
lewing
approved these changes
Sep 23, 2022
lewing
added
Servicing-approved
|
approved in email |
|
JIT failures are #75391 Approved, signed off, ready to merge. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #75774 to release/7.0
/cc @thaystg
Customer Impact
While inspecting a NULL variable of type System.ReadOnlySpan on wasm the user wasn't able to see the variable value. On mobile the user would see a crash on runtime.
Testing
Manually tested on desktop and mobile, and unit test created for wasm.
Risk
Low risk, only changing the behavior for NULL values on wasm, and allocating an extra pointer when it's decoding a ref value.
IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.