Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix repro package creation #78924

Merged
merged 3 commits into from
Dec 1, 2022
Merged

Conversation

ivanpovazan
Copy link
Member

@ivanpovazan ivanpovazan commented Nov 28, 2022

This PR fixes regression caused by System.CommandLine upgrade when creating repro packages

Fixes #78921

@ghost
Copy link

ghost commented Nov 28, 2022

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Issue Details

This PR fixes repro package creation for ILCompiler by:

  1. Covering the appropriate types received from the command line options parser (e.g., references from the response file are read as Dictionary<string,string>
  2. Adding prefix to created directories in the repro package based on their usage (e.g., _in_ for inputs, _out_ for outputs)
  3. Enabling creation of appropriate output directories in the repro package (e.g., --out:obj/Debug/native/hello.o becomes --out:_out_0/hello.o; where _out_0 is created in the archive as explained in (2))

Fixes #78921

Author: ivanpovazan
Assignees: -
Labels:

area-NativeAOT-coreclr

Milestone: -

src/coreclr/tools/Common/CommandLineHelpers.cs Outdated Show resolved Hide resolved
src/coreclr/tools/Common/CommandLineHelpers.cs Outdated Show resolved Hide resolved
src/coreclr/tools/Common/CommandLineHelpers.cs Outdated Show resolved Hide resolved
@MichalStrehovsky
Copy link
Member

Cc @dotnet/ilc-contrib @dotnet/crossgen-contrib since this affects both compilers.

@ivanpovazan ivanpovazan changed the title Fix response file parsing and repro package creation Fix repro package creation Nov 30, 2022
Copy link
Member

@am11 am11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Member

@MichalStrehovsky MichalStrehovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

src/coreclr/tools/Common/CommandLineHelpers.cs Outdated Show resolved Hide resolved
src/coreclr/tools/Common/CommandLineHelpers.cs Outdated Show resolved Hide resolved
@ivanpovazan ivanpovazan merged commit 39b6e5e into dotnet:main Dec 1, 2022
@ivanpovazan ivanpovazan deleted the make-repro-fix branch December 1, 2022 08:17
@ghost ghost locked as resolved and limited conversation to collaborators Dec 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ILCompiler --make-repro-path option is not working in .net8
4 participants