Assign correct slots during IEnumerable resolution #80410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…merable resolution. fix dotnet#79938
ghost
added
the
community-contribution
|
Tagging subscribers to this area: @dotnet/area-extensions-dependencyinjection Issue Detailsfix #79938
|
madelson
commented
Jan 10, 2023
| Assert.IsType<FakeService>(service); | ||
| Assert.Equal(2, services.Length); | ||
| Assert.True(services.Any(s => s.GetType() == typeof(FakeService))); | ||
| Assert.True(services.Any(s => s.GetType() == typeof(FakeOpenGenericService<PocoClass>))); |
There was a problem hiding this comment.
Note: ideally we'd assert some order, but the Lamar container returns a different order than other implementations.
# Conflicts: # src/libraries/Microsoft.Extensions.DependencyInjection/src/ServiceLookup/CallSiteFactory.cs
steveharter
reviewed
Jan 26, 2023
src/libraries/Microsoft.Extensions.DependencyInjection/src/ServiceLookup/CallSiteFactory.cs
Outdated
Show resolved
Hide resolved
...ensions.DependencyInjection.Specification.Tests/src/DependencyInjectionSpecificationTests.cs
Show resolved
Hide resolved
|
I'll take a look at this. |
|
@davidfowl any thoughts? |
|
cc previous owners @maryamariyan and @eerhardt to get some more eyes on this. Thanks |
|
@davidfowl going once... |
steveharter
approved these changes
Jun 8, 2023
...ensions.DependencyInjection.Specification.Tests/src/DependencyInjectionSpecificationTests.cs
Show resolved
Hide resolved
...ies/Microsoft.Extensions.DependencyInjection/tests/DI.Tests/ServiceProviderContainerTests.cs
Show resolved
Hide resolved
|
LGTM; updated to |
steveharter
changed the title
|
Thanks @madelson! |
|
Two unrelated CI crashes in |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #79938
(issue with open generic)
fixes #87017
(issue with having an existing enumerable)