-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wasm] Add narrow methods to PackedSimd #83084
[wasm] Add narrow methods to PackedSimd #83084
Conversation
Add them as internal as the approved API contains wrong methods for these. dotnet#53730 (comment) This will allow faster implementation of IndexOfAnyValues for wasm. dotnet#82789 (comment)
Tagging subscribers to this area: @dotnet/area-system-runtime-intrinsics Issue DetailsAdd them as internal as the approved API contains wrong methods for these. #53730 (comment) This will allow faster implementation of IndexOfAnyValues for wasm. #82789 (comment)
|
As the documentation is a bit unclear (the text and binary format parts could be explained differently about the inputs), I checked the results with this test, running with node. It looks like the inputs are indeed treated as signed integers here.
|
The relevant code from the test above:
|
The failing builds are unrelated |
Add them as internal as the approved API contains wrong methods for these. #53730 (comment)
This will allow faster implementation of IndexOfAnyValues for wasm. #82789 (comment)