Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a read-out-of-local error in the MD library. #83906

Merged
merged 2 commits into from
Mar 25, 2023
Merged

Fix a read-out-of-local error in the MD library. #83906

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f77a450
Fix a read-out-of-local error in the MD library.
jkoritzinsky Mar 24, 2023
65fc84c
Fix build error
jkoritzinsky Mar 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/coreclr/md/runtime/metamodel.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -717,13 +717,17 @@ CMiniMdBase::InitColsForTable(
// should we write the data into the structure
{
const CMiniTableDef *pTemplate; // Template table definition.
CMiniColDef pCols[9]; // The col defs to init.
// Mark the array of columns as not allocated (not ALLOCATED_MEMORY_MARKER) for SetNewColumnDefinition
const uint8_t MAX_COL_COUNT = 9;
BYTE colData[1 + sizeof(CMiniColDef) * MAX_COL_COUNT];
colData[0] = 0;
CMiniColDef* pCols = BYTEARRAY_TO_COLDES(colData);
BYTE iOffset; // Running size of a record.
BYTE iSize; // Size of a field.
HRESULT hr = S_OK;

_ASSERTE((bExtra == 0) || (bExtra == 1));
_ASSERTE(ARRAY_SIZE(pCols) >= pTable->m_cCols);
_ASSERTE(MAX_COL_COUNT >= pTable->m_cCols);

bExtra = 0;//<TODO>@FUTURE: save in schema header. until then use 0.</TODO>

Expand Down