-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eliminate bound checks for "arr[arr.Length - cns]" #84213
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
Apr 1, 2023
ghost
assigned EgorBo
Apr 1, 2023
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak Issue Detailsvoid Test(int[] arr)
{
if (arr.Length == 0 || arr[arr.Length - 1] == 0)
{
Console.WriteLine();
}
} Was: ; Method Prog:Test(int[]):this
sub rsp, 40
mov eax, dword ptr [rdx+08H]
test eax, eax
je SHORT G_M2580_IG04
lea ecx, [rax-01H]
cmp ecx, eax
jae SHORT G_M2580_IG07
mov eax, ecx
cmp dword ptr [rdx+4*rax+10H], 0
jne SHORT G_M2580_IG05
G_M2580_IG04:
call [System.Console:WriteLine()]
G_M2580_IG05:
nop
add rsp, 40
ret
G_M2580_IG07:
call CORINFO_HELP_RNGCHKFAIL
int3
; Total bytes of code: 45 New: ; Method Prog:Test(int[]):this
sub rsp, 40
mov eax, dword ptr [rdx+08H]
test eax, eax
je SHORT G_M2580_IG04
dec eax
cmp dword ptr [rdx+4*rax+10H], 0
jne SHORT G_M2580_IG05
G_M2580_IG04:
call [System.Console:WriteLine()]
G_M2580_IG05:
nop
add rsp, 40
ret
; Total bytes of code: 32
|
@AndyAyersMS @jakobbotsch @dotnet/jit-contrib PTAL |
Diffs, no TP impact. |
AndyAyersMS
approved these changes
Apr 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: #84210 (comment)
Previous codegen:
New codegen: