Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for test build break in the outerloop pipeline #84649

Merged
merged 1 commit into from
Apr 12, 2023

Conversation

trylek
Copy link
Member

@trylek trylek commented Apr 11, 2023

The PR

#84383

missed one case that is now causing build errors in the Pri1 test suite. I have attempted to fix this along the lines of the above PR.

Thanks

Tomas

/cc @dotnet/crossgen-contrib, @dotnet/ilc-contrib

Example run:

https://dev.azure.com/dnceng-public/public/_build/results?buildId=234211&view=logs&j=3725811e-4a8b-5f6a-b03b-a353ee894148&t=d59fccfb-2b13-5841-75bf-bfec705ee16a

Diagnostics:

    Lib -> /__w/1/s/artifacts/tests/coreclr/AnyOS.x64.Checked/Loader/classloader/generics/Variance/Delegates/Lib/Lib.dll
/__w/1/s/src/coreclr/tools/Common/TypeSystem/Ecma/EcmaField.cs(150,40): error SYSLIB0050: 'FieldAttributes.NotSerialized' is obsolete: 'Formatter-based serialization is obsolete and should not be used.' [/__w/1/s/src/tests/ilverify/ILVerificationTests.csproj] [/__w/1/s/src/tests/build.proj]
##[error]src/coreclr/tools/Common/TypeSystem/Ecma/EcmaField.cs(150,40): error SYSLIB0050: 'FieldAttributes.NotSerialized' is obsolete: 'Formatter-based serialization is obsolete and should not be used.' [/__w/1/s/src/tests/ilverify/ILVerificationTests.csproj]
    Lib -> /__w/1/s/artifacts/tests/coreclr/AnyOS.x64.Checked/Loader/classloader/generics/Variance/IL/Lib/Lib.dll

The PR

dotnet#84383

missed one case that is now causing build errors in the Pri1 test
suite. I have attempted to fix this along the lines of the above
PR.

Thanks

Tomas
@trylek
Copy link
Member Author

trylek commented Apr 11, 2023

/azp run runtime-coreclr outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@trylek
Copy link
Member Author

trylek commented Apr 11, 2023

Fixing the primary test build break uncovered a secondary bug on Windows arm in the frozen test, I'll follow up on that once we're done with the build break.

Copy link
Member

@MichalStrehovsky MichalStrehovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll be able to delete this code because IsNotSerialized is now unused, but that can be done later.

@kunalspathak
Copy link
Member

Failure is #84462

@kunalspathak kunalspathak merged commit f4701e2 into dotnet:main Apr 12, 2023
@trylek trylek deleted the OuterloopPipelineFix branch April 12, 2023 09:31
@ghost ghost locked as resolved and limited conversation to collaborators May 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants