Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Parallel.ForAsync #84804

Merged
merged 2 commits into from
Apr 25, 2023
Merged

Add Parallel.ForAsync #84804

merged 2 commits into from
Apr 25, 2023

Conversation

stephentoub
Copy link
Member

Fixes #59019

@ghost
Copy link

ghost commented Apr 13, 2023

Tagging subscribers to this area: @dotnet/area-system-threading-tasks
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #59019

Author: stephentoub
Assignees: -
Labels:

area-System.Threading.Tasks
Milestone: -

@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost ghost assigned stephentoub Apr 13, 2023
@build-analysis build-analysis bot mentioned this pull request Apr 14, 2023
Closed
carlossanlop
carlossanlop approved these changes Apr 24, 2023
View reviewed changes
Copy link
Member

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some docs suggestions. LGTM.

src/libraries/System.Threading.Tasks.Parallel/ref/System.Threading.Tasks.Parallel.cs Show resolved Hide resolved
...ibraries/System.Threading.Tasks.Parallel/src/System/Threading/Tasks/Parallel.ForEachAsync.cs Outdated Show resolved Hide resolved
...ibraries/System.Threading.Tasks.Parallel/src/System/Threading/Tasks/Parallel.ForEachAsync.cs Outdated Show resolved Hide resolved
...ibraries/System.Threading.Tasks.Parallel/src/System/Threading/Tasks/Parallel.ForEachAsync.cs Show resolved Hide resolved
...ibraries/System.Threading.Tasks.Parallel/src/System/Threading/Tasks/Parallel.ForEachAsync.cs Outdated Show resolved Hide resolved
...ibraries/System.Threading.Tasks.Parallel/src/System/Threading/Tasks/Parallel.ForEachAsync.cs Outdated Show resolved Hide resolved
...ibraries/System.Threading.Tasks.Parallel/src/System/Threading/Tasks/Parallel.ForEachAsync.cs Outdated Show resolved Hide resolved
...ibraries/System.Threading.Tasks.Parallel/src/System/Threading/Tasks/Parallel.ForEachAsync.cs Outdated Show resolved Hide resolved
...ibraries/System.Threading.Tasks.Parallel/src/System/Threading/Tasks/Parallel.ForEachAsync.cs Outdated Show resolved Hide resolved
src/libraries/System.Threading.Tasks.Parallel/tests/ParallelForEachAsyncTests.cs Show resolved Hide resolved
@stephentoub @carlossanlop
Apply suggestions from code review
ddbfc25 
Co-authored-by: Carlos Sánchez López <1175054+carlossanlop@users.noreply.github.com>
@stephentoub stephentoub merged commit 516aa8c into dotnet:main Apr 25, 2023
@stephentoub stephentoub deleted the parallelforasync branch April 25, 2023 02:51
This was referenced Apr 25, 2023
Open
Closed
Closed
@AndyAyersMS AndyAyersMS mentioned this pull request May 7, 2023
Closed
@ghost ghost locked as resolved and limited conversation to collaborators May 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@carlossanlop carlossanlop carlossanlop approved these changes

@danmoseley danmoseley danmoseley left review comments

Assignees

@stephentoub stephentoub

Labels
area-System.Threading.Tasks new-api-needs-documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[API Proposal]: Parallel.ForAsync
3 participants
@stephentoub @carlossanlop @danmoseley