Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete GT_FIELD #85568

Merged
merged 3 commits into from
May 3, 2023
Merged

Conversation

SingleAccretion
Copy link
Contributor

@SingleAccretion SingleAccretion commented Apr 30, 2023

With the removal ASG, FIELD is the only location node that does not have a STORE equivalent, thus this change removes it in favor of importing IND/BLK(FIELD_ADDR).

Diffs:

  1. Code - a number of quirks had to be applied in order to keep those down, but many still remain. Common theme is lack of forward substitution due to the 16 node limit. There are a number of other reasons as well, e. g. on x86 we now spill a FIELD_ADDR return buffer argument for a GDV call arg because it is correctly marked with GTF_EXCEPT.
  2. TP - a bit of a significant regression due to the IR size increase, payed for with Delete OBJ(LCL_ADDR) args handling from local morph ref counting #85544.

A number of TODO-FIELDs were added, I intend to address them separately.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Apr 30, 2023
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Apr 30, 2023
@ghost
Copy link

ghost commented Apr 30, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

With the removal ASG, FIELD is the only location node that does not have a STORE equivalent, thus this change removes it in favor of importing IND/BLK(FIELD_ADDR).

Diffs:

  1. Code - a number of quirks had to be applied in order to keep those down, but many still remain. Common theme is lack of forward substitution due to the 16 node limit affecting things downstream.
  2. TP - a bit of significant regression due to the IR size increase, payed for with Delete OBJ(LCL_ADDR) args handling from local morph ref counting #85544.

A number of TODO-FIELDs were added, I intend to address them separately.

Author: SingleAccretion
Assignees: -
Labels:

area-CodeGen-coreclr, community-contribution

Milestone: -

@SingleAccretion SingleAccretion force-pushed the No-Field-Node-Upstream branch 4 times, most recently from d347221 to 6ea357a Compare April 30, 2023 20:39
@SingleAccretion SingleAccretion marked this pull request as ready for review May 1, 2023 18:11
@SingleAccretion
Copy link
Contributor Author

Diffs - see header comment.

@dotnet/jit-contrib

Copy link
Member

@jakobbotsch jakobbotsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice to see these gone.

@jakobbotsch
Copy link
Member

Failure is known.

@jakobbotsch jakobbotsch merged commit 458f3de into dotnet:main May 3, 2023
@SingleAccretion SingleAccretion deleted the No-Field-Node-Upstream branch May 3, 2023 20:19
@ghost ghost locked as resolved and limited conversation to collaborators Jun 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants