Remove S.Sec.Crypto.Algorithms package dependency #85701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributes to dotnet#85641 System.Security.Cryptography.Algorithms/4.3.1 is being referenced in a few .NET Framework builds. The reference to that package is undesirable as it brings in the entire netstandard 1.x dependency graph. The only type used from that package is IncrementalHash which isn't available as a public API in .NET Framework before 4.7.1. Because of that, polyfill the netfx code in with minor changes to the source to make the analyzers happy.
|
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries Issue DetailsContributes to #85641 System.Security.Cryptography.Algorithms/4.3.1 is being referenced in a few .NET Framework builds. The reference to that package is undesirable as it brings in the entire netstandard 1.x dependency graph. The only type used from that package is IncrementalHash which isn't available as a public API in .NET Framework before 4.7.1. Because of that, polyfill the netfx code with minor changes to make the analyzers happy in (including string resources).
|
This was referenced May 3, 2023
vcsjones
reviewed
May 3, 2023
src/libraries/System.Reflection.Metadata/tests/System.Reflection.Metadata.Tests.csproj
Outdated
Show resolved
Hide resolved
src/libraries/System.Security.Cryptography.Cose/src/System.Security.Cryptography.Cose.csproj
Show resolved
Hide resolved
src/libraries/Common/src/System/Security/Cryptography/IncrementalHash.netfx.cs
Show resolved
Hide resolved
carlossanlop
approved these changes
May 3, 2023
vcsjones
approved these changes
May 3, 2023
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #85641
System.Security.Cryptography.Algorithms/4.3.1 is being referenced in a few .NET Framework builds. The reference to that package is undesirable as it brings in the entire netstandard 1.x dependency graph.
The only type used from that package is IncrementalHash which isn't available as a public API in .NET Framework before 4.7.1. Because of that, polyfill the netfx code with minor changes to make the analyzers happy in (including string resources).