Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GetNonGCHeapBounds #85702

Merged
merged 1 commit into from
May 4, 2023
Merged

Fix GetNonGCHeapBounds #85702

merged 1 commit into from
May 4, 2023

Conversation

EgorBo
Copy link
Member

@EgorBo EgorBo commented May 3, 2023 •
edited
Loading

Addresses #85434 (comment)

@ghost ghost assigned EgorBo May 3, 2023
@ghost
Copy link

ghost commented May 3, 2023

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

Issue Details

Addresses #85434 (comment)

  • decrease FOH segment size in Debug so we have more chances to test logic with multiple segments
Author: EgorBo
Assignees: EgorBo
Labels:

area-Diagnostics-coreclr
Milestone: -

@EgorBo
Copy link
Member Author

EgorBo commented May 3, 2023

/azp run runtime-coreclr outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@EgorBo EgorBo force-pushed the fix-profiler-nongcboundaries-api branch from b66a129 to bf35676 Compare May 3, 2023 12:37
@EgorBo
Copy link
Member Author

EgorBo commented May 3, 2023

@noahfalk @davmason

This was referenced May 3, 2023
Closed
Closed
noahfalk
noahfalk approved these changes May 4, 2023
View reviewed changes
Copy link
Member

@noahfalk noahfalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@EgorBo
Copy link
Member Author

EgorBo commented May 4, 2023

Failure is #85637

@EgorBo EgorBo merged commit 87189ec into dotnet:main May 4, 2023
@EgorBo EgorBo deleted the fix-profiler-nongcboundaries-api branch May 4, 2023 00:38
@ghost ghost locked as resolved and limited conversation to collaborators Jun 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@noahfalk noahfalk noahfalk approved these changes

Assignees

@EgorBo EgorBo

Labels
area-Diagnostics-coreclr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EgorBo @noahfalk