[release/8.0-preview5] Use fully qualified type names for parameters and don't copy parameter attributes #86899
Conversation
…r attributes The issue dotnet/source-build#3483 looks similar to the issues I found before fixing in #86731. The relevant changes were in ComMethodContext.cs. If it's the same issue I was hitting, the attribute syntax was being copied over without adding 'using' statements or changing the attribute name to be fully qualified. I haven't validated yet, but this should fix it by just not copying the attributes for the parameters since they're not strictly necessary.
|
Tagging subscribers to this area: @dotnet/interop-contrib Issue DetailsThe issue dotnet/source-build#3483 looks similar to the issues I found before fixing in #86731. The relevant changes were in ComMethodContext.cs. If it's the same issue I was hitting, the attribute syntax was being copied over without adding 'using' statements or changing the attribute name to be fully qualified. I haven't validated yet, but this should fix it by just not copying the attributes for the parameters since they're not strictly necessary.
|
lewing
changed the title
hoyosjs
added
Servicing-approved
|
@jtschuster @jkoritzinsky @mthalman I see the test was added. There were test failures. Let me know if they are not related and if this is ready to merge. |
|
The failures look like unrelated internet issues. I'll let @jkoritzinsky confirm, but it should be ready to merge. |
|
yeah wasm failure doesn't look related |
|
The CI got reset with the branch merge. But since the CI passed before, I'll merge. |
|
/backport to main |
|
Started backporting to main: https://github.com/dotnet/runtime/actions/runs/5126550773 |
ghost
locked as resolved and limited conversation to collaborators
Fixes dotnet/source-build#3483 by not copying the attributes for the parameters on generated base implementation methods since they're not strictly necessary.