[Mono] Add coreclr_shutdown to mono #88594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a crash seen in netcordbg due to unavailability of coreclr_shutdown in mono. Implemented it for mono.
giritrivedi
requested review from
vargaz,
lambdageek and
SamMonoRT
as code owners
dotnet-issue-labeler
bot
added
the
needs-area-label
ghost
added
the
community-contribution
teo-tsirpanis
added
area-VM-meta-mono
and removed
needs-area-label
lambdageek
approved these changes
Jul 10, 2023
lambdageek
reviewed
Jul 10, 2023
src/mono/mono/mini/main-core.c
Outdated
| @@ -19,6 +19,7 @@ | |||
| #pragma comment(linker, "/export:coreclr_initialize=_coreclr_initialize@28") | |||
| #pragma comment(linker, "/export:coreclr_execute_assembly=_coreclr_execute_assembly@24") | |||
| #pragma comment(linker, "/export:coreclr_shutdown_2=_coreclr_shutdown_2@12") | |||
| #pragma comment(linker, "/export:coreclr_shutdown=_coreclr_shutdown@13") | |||
There was a problem hiding this comment.
build failures suggest this decorated name should end with @8
Suggested change
| #pragma comment(linker, "/export:coreclr_shutdown=_coreclr_shutdown@13") | |
| #pragma comment(linker, "/export:coreclr_shutdown=_coreclr_shutdown@8") |
This was referenced Jul 11, 2023
|
@lambdageek Modified the code accordingly. Thanks for the help |
|
Failures are known |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a crash seen while working on netcordbg due to unavailability of coreclr_shutdown
for mono. Implemented the missing code for mono.