Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gen0 Budget counter #89412

Merged
merged 5 commits into from
Jul 28, 2023
Merged

Gen0 Budget counter #89412

merged 5 commits into from
Jul 28, 2023

Conversation

cshung
Copy link
Member

@cshung cshung commented Jul 24, 2023 •
edited
Loading

@cshung cshung self-assigned this Jul 24, 2023
@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost
Copy link

ghost commented Jul 24, 2023

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

Issue Details

WIP - testing only. Meant to fix #74217

In order to get it to work - I have to expose a new public API. The new API is not approved yet, do not merge.

Author: cshung
Assignees: cshung
Labels:

area-Diagnostics-coreclr
Milestone: -

Maoni0
Maoni0 reviewed Jul 26, 2023
View reviewed changes
src/coreclr/gc/gc.cpp Outdated Show resolved Hide resolved
Maoni0
Maoni0 reviewed Jul 26, 2023
View reviewed changes
src/coreclr/gc/gc.cpp Outdated Show resolved Hide resolved
Maoni0
Maoni0 reviewed Jul 26, 2023
View reviewed changes
src/coreclr/gc/gc.cpp Outdated Show resolved Hide resolved
@build-analysis build-analysis bot mentioned this pull request Jul 27, 2023
Closed
@build-analysis build-analysis bot mentioned this pull request Jul 27, 2023
Closed
Maoni0
Maoni0 approved these changes Jul 27, 2023
View reviewed changes
Copy link
Member

@Maoni0 Maoni0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cshung cshung merged commit 0dd733e into dotnet:main Jul 28, 2023
167 of 170 checks passed
@cshung cshung deleted the public/budget branch July 28, 2023 17:12
@mangod9 mangod9 mentioned this pull request Jul 31, 2023
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Aug 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mrsharm mrsharm mrsharm left review comments

@hoyosjs hoyosjs hoyosjs left review comments

@Wraith2 Wraith2 Wraith2 left review comments

@Maoni0 Maoni0 Maoni0 approved these changes

@marek-safar marek-safar Awaiting requested review from marek-safar

@MichalStrehovsky MichalStrehovsky Awaiting requested review from MichalStrehovsky MichalStrehovsky is a code owner

Assignees

@cshung cshung

Labels
area-Diagnostics-coreclr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a counter for gen0 budget
5 participants
@cshung @Maoni0 @Wraith2 @hoyosjs @mrsharm