Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make TypeDescriptor thread safe with custom providers by enlarging lock region #92521

Closed
wants to merge 13 commits into from
Closed

Make TypeDescriptor thread safe with custom providers by enlarging lock region #92521

wants to merge 13 commits into from

Commits on Sep 23, 2023

  1. minimal entirety lock to fix bug

    @karakasa
    karakasa committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    56fd769 View commit details
    Browse the repository at this point in the history

  2. remove unused code

    @karakasa
    karakasa committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    47d9fe6 View commit details
    Browse the repository at this point in the history

  3. minimize lock range

    @karakasa
    karakasa committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    7b743c3 View commit details
    Browse the repository at this point in the history

  4. add test

    @karakasa
    karakasa committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    ba1e176 View commit details
    Browse the repository at this point in the history

  5. fix code style

    @karakasa
    karakasa committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    49aef1a View commit details
    Browse the repository at this point in the history

  6. Make TypeDescriptor thread safe with custom providers 

    Originally a race condition exists in `CheckDefaultProvider` and leads
to wrong results when many methods are called simultaneously.

The PR fixes that by extending the lock statement.

Fix dotnet#92934
    @karakasa
    karakasa committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    a8a259c View commit details
    Browse the repository at this point in the history

  7. Originally a race condition exists in CheckDefaultProvider and leads 

    to wrong results when many methods are called simultaneously.

The PR fixes that by extending the lock statement.

Fix dotnet#92394
    @karakasa
    karakasa committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    e4c4296 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2023

  1. Added another HashTable to reduce locks. 

    Moved tests to the main testing file
Adopted tests from dotnet#85156

Co-authored-by: Maximys <mixim33@yandex.ru>
    @karakasa @Maximys
    karakasa and Maximys committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    8a7df35 View commit details
    Browse the repository at this point in the history

  2. better test names

    @karakasa
    karakasa committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    0e3fc99 View commit details
    Browse the repository at this point in the history

  3. improve comments

    @karakasa
    karakasa committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    b067518 View commit details
    Browse the repository at this point in the history

  4. renamed variable

    @karakasa
    karakasa committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    c55d876 View commit details
    Browse the repository at this point in the history

  5. reverted sln file

    @karakasa
    karakasa committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    8707cd9 View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2023

  1. Skip one test on browsers 

    ConcurrentGetProperties_ReturnsExpected
is skipped on browsers because Thread.Start
is unsupported.
    @karakasa
    karakasa authored Nov 16, 2023
    Configuration menu
    Copy the full SHA
    33d5a3e View commit details
    Browse the repository at this point in the history